Should I unsubscribe from events? [duplicate]

by

Well, let’s take the last question first. You can’t reliably unsubscribe from an event that you’ve subscribed to directly with a lambda expression. You either need to keep a variable around with the delegate in (so you can still use a lambda expression) or you need to use a method group conversion instead.

Now as for whether you actually need to unsubscribe, it depends on the relationship between the event producer and the event consumer. If the event producer should live for longer than the event consumer, you should unsubscribe – because otherwise the producer will have a reference to the consumer, keeping it alive for longer than it should be. The event handler will also keep getting called for as long as the producer produces it.

Now in many cases that’s not a problem – for example, in a form the button that raises the Click event is likely to live for about as long as the form on which it’s created, where the handler is typically subscribed… so there’s no need to unsubscribe. This is very typical for a GUI.

Likewise if you create a WebClient solely for the purpose of a single asynchronous request, subscribe to the relevant event and start the asynchronous request, then the WebClient itself will be eligible for garbage collection when the request has finished (assuming you don’t keep a reference elsewhere).

Basically, you should always consider the relationship between the producer and the consumer. If the producer is going to live longer than you want the consumer to, or it’s going to continue raising the event after you’re no longer interested in it, then you should unsubscribe.

More Related Contents:

  1. Understanding events and event handlers in C#
  2. C# Events and Thread Safety
  3. How do I await events in C#?
  4. Is it bad to not unregister event handlers?
  5. Simple event system in Unity
  6. C#: Raising an inherited event
  7. How do I Unregister ‘anonymous’ event handler [duplicate]
  8. Detect active window changed using C# without polling
  9. How to ensure an event is only subscribed to once
  10. How to add an event to a UserControl in C#?
  11. Determine list of event handlers bound to event
  12. How to pass an event to a method?
  13. Raise an event of a class from a different class in C#
  14. How do I get the subscribers of an event?
  15. How to ‘await’ raising an EventHandler event
  16. Are C# events synchronous?
  17. How to Query for an event log details with a given event id?
  18. Microsoft Visual Studio and C#: How to Visually Add Events to Controls?
  19. How is this possible: OnPaint processed while in WaitOne
  20. How can I clear event subscriptions in C#?
  21. How to make Form1 label.text change when checkbox on form2 is checked?
  22. Events – naming convention and style
  23. In a C# event handler, why must the “sender” parameter be an object?
  24. How do I raise an event in a usercontrol and catch it in mainpage?
  25. Post Publish Events
  26. Detect when a form has been closed c#
  27. array of events in C#?
  28. Fire Form KeyPress event
  29. C# event debounce
  30. How to use Application.Exit Event in WPF?

Leave a Comment