Should I use the final modifier when declaring case classes?

by

It is not redundant in the sense that using it does change things. As one would expect, you cannot extend a final case class, but you can extend a non-final one.
Why does wartremover suggest that case classes should be final? Well, because extending them isn’t really a very good idea. Consider this:

scala> case class Foo(v:Int)
defined class Foo

scala> class Bar(v: Int, val x: Int) extends Foo(v)
defined class Bar

scala> new Bar(1, 1) == new Bar(1, 1)
res25: Boolean = true

scala> new Bar(1, 1) == new Bar(1, 2)
res26: Boolean = true
// ????

Really? Bar(1,1) equals Bar(1,2)? This is unexpected. But wait, there is more:

scala> new Bar(1,1) == Foo(1)
res27: Boolean = true

scala> class Baz(v: Int) extends Foo(v)
defined class Baz

scala> new Baz(1) == new Bar(1,1)
res29: Boolean = true //???

scala> println (new Bar(1,1))
Foo(1) // ???

scala> new Bar(1,2).copy()
res49: Foo = Foo(1) // ???

A copy of Bar has type Foo? Can this be right?

Surely, we can fix this by overriding the .equals (and .hashCode, and .toString, and .unapply, and .copy, and also, possibly, .productIterator, .productArity, .productElement etc.) method on Bar and Baz. But “out of the box”, any class that extends a case class would be broken.

This is the reason, you can no longer extend a case class by another case class, it has been forbidden since, I think scala 2.11. Extending a case class by a non-case class is still allowed, but, at least, in wartremover’s opinion isn’t really a good idea.

More Related Contents:

  1. Case objects vs Enumerations in Scala
  2. Cleaner way to update nested structures
  3. Case class equality in Apache Spark
  4. What is the difference between Scala’s case class and class?
  5. How to define schema for custom type in Spark SQL?
  6. How to override apply in a case class companion
  7. How to get around the Scala case class limit of 22 fields?
  8. Case class to map in Scala
  9. Mixing in a trait dynamically
  10. Easy idiomatic way to define Ordering for a simple case class
  11. Scala Macros: Making a Map out of fields of a class in Scala
  12. What is *so* wrong with case class inheritance?
  13. Scala case class inheritance
  14. Overload constructor for Scala’s Case Classes?
  15. Why is parameter in contravariant position?
  16. Scala 2.10 reflection, how do I extract the field values from a case class, i.e. field list from case class
  17. “dynamically” creating case classes with macros
  18. How is this case class match pattern working?
  19. Apache Spark – Scala – ReduceByKey – with keys repeating up to twice only
  20. Underscore in Named Arguments
  21. How to import build.gradle into IntelliJ
  22. Spark dataframe write method writing many small files
  23. Scala 2.8 collections design tutorial
  24. Scala classOf for type parameter
  25. What are possible reasons for receiving TimeoutException: Futures timed out after [n seconds] when working with Spark [duplicate]
  26. Why does join fail with “java.util.concurrent.TimeoutException: Futures timed out after [300 seconds]”?
  27. Create new Dataframe with empty/null field values
  28. How to prevent java.lang.OutOfMemoryError: PermGen space at Scala compilation?
  29. Futures / Success race
  30. Why does one select Scala type members with a hash instead of a dot?

Leave a Comment