Should I use two “where” clauses or “&&” in my LINQ query?

by

I personally would always go with the && vs. two where clauses whenever it doesn’t make the statement unintelligible.

In your case, it probably won’t be noticeble at all, but having 2 where clauses definitely will have a performance impact if you have a large collection, and if you use all of the results from this query. For example, if you call .Count() on the results, or iterate through the entire list, the first where clause will run, creating a new IEnumerable<T> that will be completely enumerated again, with a second delegate.

Chaining the 2 clauses together causes the query to form a single delegate that gets run as the collection is enumerated. This results in one enumeration through the collection and one call to the delegate each time a result is returned.

If you split them, things change. As your first where clause enumerates through the original collection, the second where clause enumerates its results. This causes, potentially (worst case), 2 full enumerations through your collection and 2 delegates called per member, which could mean this statement (theoretically) could take 2x the runtime speed.

If you do decide to use 2 where clauses, placing the more restrictive clause first will help quite a bit, since the second where clause is only run on the elements that pass the first one.

Now, in your case, this won’t matter. On a large collection, it could. As a general rule of thumb, I go for:

  1. Readability and maintainability

  2. Performance

In this case, I think both options are equally maintainable, so I’d go for the more performant option.

More Related Contents:

  1. C# custom add in a List
  2. Group By Multiple Columns
  3. Distinct not working with LINQ to Objects
  4. When to use Cast() and Oftype() in Linq
  5. How to get index using LINQ? [duplicate]
  6. How do I concatenate two arrays in C#?
  7. Split a collection into `n` parts with LINQ? [duplicate]
  8. Order of LINQ extension methods does not affect performance?
  9. Why is .Contains slow? Most efficient way to get multiple entities by primary key?
  10. Query an XDocument for elements by name at any depth
  11. Entity Framework/Linq EXpression converting from string to int
  12. How to flatten nested objects with linq expression
  13. What is the point of Lookup?
  14. Difference between Lookup() and Dictionary(Of list())
  15. How to convert an expression tree to a partial SQL query?
  16. Apply function to all elements of collection through LINQ [duplicate]
  17. How to convert linq results to HashSet or HashedSet
  18. Is the Linq Count() faster or slower than List.Count or Array.Length?
  19. IEqualityComparer for SequenceEqual
  20. LINQ – Query syntax vs method chains & lambda [closed]
  21. Resolving extension methods/LINQ ambiguity
  22. C# Is there a LINQ to HTML, or some other good .Net HTML manipulation API?
  23. Performance of Find() vs. FirstOrDefault() [duplicate]
  24. What does this C# code with an “arrow” (=>, an equal sign and greater than sign) mean and how is it called?
  25. Using Linq Except not Working as I Thought
  26. What is the purpose of AsQueryable()?
  27. LINQ query to return a Dictionary
  28. A dictionary where value is an anonymous type in C#
  29. Expressing recursion in LINQ
  30. C# Searching for files and folders except in certain folders

Leave a Comment