Static class instance inside class

by

What you have there is a static method getLibrary() that returns the same instance for all callers. That’s called a Singleton – although there’s better ways to code them.

Then again your supposed Singleton (TestLibrary) exhibits methods that when called change internal state – most important, the ErrorHandler.

This will cause strange behaviour, especially in multithreaded systems.

Code like this:

TestLibrary.getLibrary().run("".split(""));
ErrorHandler eh = TestLibrary.getErrorHandler();
assertEquals(eh, TestLibrary.getErrorHandler());

might fail. Because someone (meaning: some other thread) might have just happend to call init() between lines 2 and 3, causing ErrorHandler to be set to just another value.

If you need to initialize your TestLibrary before use, you should do it once, and once only – so you’re better of putting this into the constructor of TestLibrary.

If you need TestLibraries that are intialized different throughout your code, you should remove the Singleton pattern and stick to plain 

  TestLibrary tl = new TestLibrary();
  tl.run("".split(""));

Read more about Singleton in What is an efficient way to implement a singleton pattern in Java?

More Related Contents:

  1. Why is a non-static variable not able to be referenced from a static context?
  2. JAVA- JFrame- non static method cannot be referenced from a static context [duplicate]
  3. Use of Private static
  4. Why does my ArrayList contain N copies of the last item added to the list?
  5. What does the ‘static’ keyword do in a class?
  6. What is the reason behind “non-static method cannot be referenced from a static context”? [duplicate]
  7. Why doesn’t Java allow overriding of static methods?
  8. Difference between Static methods and Instance methods
  9. Are static fields open for garbage collection?
  10. Why would a static nested interface be used in Java?
  11. When are static variables initialized?
  12. Getting the class name from a static method in Java
  13. Why can’t we have static method in a (non-static) inner class (pre-Java 16)?
  14. Why can’t we use ‘this’ keyword in a static method
  15. Behaviour of final static method
  16. Static fields on a null reference in Java
  17. Why can’t I declare static methods in an interface?
  18. Invoking a static method using reflection
  19. static allocation in java – heap, stack and permanent generation
  20. in what order are static blocks and static variables in a class executed? [duplicate]
  21. Why are all fields in an interface implicitly static and final?
  22. How do I mock static methods in a class with easymock?
  23. Are static variables inherited
  24. What does `public static void main args` mean?
  25. Are non-synchronised static methods thread safe if they don’t modify static class variables?
  26. When to use static variables/methods and when to use instance variables/methods in Java? [closed]
  27. @Autowired and static method
  28. Static variables and multithreading in java
  29. Whats up with static memory in java?
  30. Difference between Dynamic and Static type assignments in Java

Leave a Comment