String.equals() argument ordering

by

Bill Pugh asked this question at Devoxx 2011. The vast majority of people went for the form "xyz".equals(str). I am with Bill, now preferring str.equals("xyz").

It’s fundamental to the Java tradition that we find errors as early as reasonably possible. NPEs are exceptionally common. We want to route these nulls out as soon as possible.

If you’re expecting the reference to maybe null, then I don’t particularly object to the backwards notation. It’s nice to be explicit and easier to understand that there may be a null with a separate null check, but the reverse order should be well understood and sufficiently differentiate the code from the normal case where null is forbidden.

Working in security, some of the bugs null-tolerance accommodates are vulnerabilities.

More Related Contents:

  1. java program find duplicate value by negation solution error java.lang.ArrayIndexOutOfBoundsException: -3 [duplicate]
  2. How do I “decompile” Java class files? [closed]
  3. Java Timer vs ExecutorService?
  4. How to sanity check a date in Java
  5. How to schedule a periodic task in Java?
  6. Run piece of code contained in a String
  7. Spring Boot – Cannot determine embedded database driver class for database type NONE
  8. How is String concatenation implemented in Java 9?
  9. Rounding BigDecimal to *always* have two decimal places
  10. UNEXPECTED TOP-LEVEL EXCEPTION: com.android.dex.DexException: Multiple dex files define
  11. Are there inline functions in java?
  12. Can I improve performance of this regular expression further
  13. JVM heap parameters
  14. In which language are the Java compiler and JVM written?
  15. Why should one use Objects.requireNonNull()?
  16. requestLegacyExternalStorage is not working in Android 11 – API 30
  17. Why DispatcherServlet creates another application context?
  18. Adding a Scrollable JTextArea (Java)
  19. Prevent suffix from being added to resources when page loads
  20. JPA (Hibernate) and custom table prefixes
  21. How to know when a user has really released a key in Java?
  22. How to inject ApplicationContext itself
  23. Add Buttons to Tabs and Tab area JavaFX
  24. How can I change charts generated by apache poi to not use smoothed lines and show empty cells as gaps?
  25. jFormattedTextField’s Formatter.setCommitsOnValidEdit(true) doesn’t work at first focus
  26. Return a stream with Spring MVC’s ResponseEntity
  27. Java: How to call super().super() in overridden method (grandparent method) [duplicate]
  28. Make a upside down triangle in java
  29. Can we declare spring bean conditionally?
  30. try/catch vs null check in java

Leave a Comment