stringstream, string, and char* conversion confusion

by

stringstream.str() returns a temporary string object that’s destroyed at the end of the full expression. If you get a pointer to a C string from that (stringstream.str().c_str()), it will point to a string which is deleted where the statement ends. That’s why your code prints garbage.

You could copy that temporary string object to some other string object and take the C string from that one:

const std::string tmp = stringstream.str();
const char* cstr = tmp.c_str();

Note that I made the temporary string const, because any changes to it might cause it to re-allocate and thus render cstr invalid. It is therefor safer to not to store the result of the call to str() at all and use cstr only until the end of the full expression:

use_c_str( stringstream.str().c_str() );

Of course, the latter might not be easy and copying might be too expensive. What you can do instead is to bind the temporary to a const reference. This will extend its lifetime to the lifetime of the reference:

{
  const std::string& tmp = stringstream.str();   
  const char* cstr = tmp.c_str();
}

IMO that’s the best solution. Unfortunately it’s not very well known.

More Related Contents:

  1. How do I check if a C++ string is an int?
  2. How to read file content into istringstream?
  3. How-to write a password-safe class?
  4. C++ Extract number from the middle of a string
  5. What’s the difference between istringstream, ostringstream and stringstream? / Why not use stringstream in every case?
  6. What is the type of string literals in C and C++?
  7. Replace part of a string with another string
  8. Why is strncpy insecure?
  9. How to remove certain characters from a string in C++?
  10. How do I concatenate multiple C++ strings on one line?
  11. What makes more sense – char* string or char *string? [duplicate]
  12. Why do compilers allow string literals not to be const?
  13. C/C++: Optimization of pointers to string constants
  14. Why does C++ allow an integer to be assigned to a string?
  15. Proper way to copy C strings
  16. Why are strings in C++ usually terminated with ‘\0’?
  17. invalid conversion from ‘const char*’ to ‘char’
  18. How do you determine the size of an object in C++?
  19. String to enum in C++
  20. writing directly to std::string internal buffers
  21. What is the proper function for comparing two C-style strings?
  22. What are uses of the C++ construct “placement new”?
  23. Where are member functions stored for an object?
  24. C++: Can a macro expand “abc” into ‘a’, ‘b’, ‘c’?
  25. Converting bool to text in C++
  26. How can i estimate memory usage of std::map?
  27. Do I have to use #include beside ?
  28. Fastest way to Convert String to Binary?
  29. How can a char pointer be initialized with a string (Array of characters) but an int pointer not with an array of integer? [duplicate]
  30. How to get file extension from string in C++

Leave a Comment