You need to call erase on the iterator returned from remove_if, It should look something like this: auto new_end = std::remove_if(MyDisplayDevices.begin(), MyDisplayDevices.end(), [](const DisplayDevice3d& device) { return device.Modes.size() == 0; }); MyDisplayDevices.erase(new_end, MyDisplayDevices.end());
The correct code is: stopPoints.erase(std::remove_if(stopPoints.begin(), stopPoints.end(), [&](const stopPointPair stopPoint)-> bool { return stopPoint.first == 4; }), stopPoints.end()); You need to remove the range starting from the iterator returned from std::remove_if to the end of the vector, not only a single element. “Why?” std::remove_if swaps elements inside the vector in order to put all elements that … Read more
How about std::remove() instead: #include <algorithm> … vec.erase(std::remove(vec.begin(), vec.end(), 8), vec.end()); This combination is also known as the erase-remove idiom.