Testing stream.good() or !stream.eof() reads last line twice [duplicate]

by

You very, very rarely want to check bad, eof, and good. In particular for eof (as !stream.eof() is a common mistake), the stream currently being at EOF does not necessarily mean the last input operation failed; conversely, not being at EOF does not mean the last input was successful.

All of the stream state functions – fail, bad, eof, and good – tell you the current state of the stream rather than predicting the success of a future operation. Check the stream itself (which is equivalent to an inverted fail check) after the desired operation:

if (getline(stream, line)) {
  use(line);
}
else {
  handle_error();
}

if (stream >> foo >> bar) {
  use(foo, bar);
}
else {
  handle_error();
}

if (!(stream >> foo)) {  // operator! is overloaded for streams
  throw SomeException();
}
use(foo);

To read and process all lines:

for (std::string line; getline(stream, line);) {
  process(line);
}

Pointedly, good() is misnamed and is not equivalent to testing the stream itself (which the above examples do).

More Related Contents:

  1. Why does reading a record struct fields from std::istream fail, and how can I fix it?
  2. How to print Unicode character in C++?
  3. No matching function – ifstream open()
  4. How to output a character as an integer through cout?
  5. How to read until EOF from cin in C++
  6. Difference between iostream and iostream.h
  7. How to read a file line by line or a whole text file at once?
  8. Prevent scientific notation in ostream when using
  9. Hide user input on password prompt [duplicate]
  10. Overload handling of std::endl?
  11. Alternative function in iostream.h for getch() of conio.h?
  12. Are there any tricks to use std::cin to initialize a const variable?
  13. What exactly is streambuf? How do I use it?
  14. What is the header?
  15. Reading and writing a std::vector into a file correctly
  16. Why are C++ STL iostreams not “exception friendly”?
  17. How to use cin.fail() in c++ properly
  18. Resetting the State of a Stream
  19. When does cout flush?
  20. How can I set the decimal separator to be a comma?
  21. c++ fastest way to read only last line of text file?
  22. Do I have to use #include beside ?
  23. What is the difference between cout, cerr, clog of iostream header in c++? When to use which one?
  24. ostream chaining, output order
  25. Printing double without losing precision
  26. Using char16_t and char32_t in I/O
  27. How can I print 0x0a instead of 0xa using cout?
  28. Reading files larger than 4GB using c++ stl
  29. Wrapping FILE* with custom std::ostream
  30. Are there binary memory streams in C++

Leave a Comment