Typescript/Angular/ES6: can I finally let `hasOwnProperty()` die in for loops?

by

There’s absolutely no reason to include this check when enumerating plain objects and others that you know have no enumerable inherited properties. You are right, no reasonable modern framework does this to Object.prototype.

The death of hasOwnProperty checks has been proclaimed since 2012 🙂

Am I only at risk of problems caused by my own team accidentally modifying prototypes (or accidentally importing libraries that modify prototypes)?

Yes. Though the fix for such problems is not to modify prototypes (or to make the property non-enumerable), not to add hasOwnProperty checks everywhere.

Or is there more room for trouble that I’m not aware of?

No.

Actually, omitting the if (!object.hasOwnProperty(key)) check might even solve some problems and avoid trouble. Not all objects you might want to enumerate are guaranteed to have a hasOwnProperty method, or one that does what you expect. The proper way to check – in cases where it is necessary – has always been with call:

if (!Object.prototype.hasOwnProperty.call(object, key))

(though of course there still are edge cases, but they don’t depend on object)

More Related Contents:

  1. Should I write methods as arrow functions in Angular’s class
  2. Angular4 Load external html page in a div
  3. How do I pass data to Angular routed components?
  4. How can I get new selection in “select” in Angular 2?
  5. Ionic 2 – global NavBar for the app
  6. Angular: How to correctly implement APP_INITIALIZER
  7. Angular 2 – 2 Way Binding with NgModel in NgFor
  8. No provider for HttpClient
  9. Argument of type ‘string | null’ is not assignable to parameter of type ‘string’. Type ‘null’ is not assignable to type ‘string’
  10. Angular Material: mat-select not selecting default
  11. How to access a constant in an Angular 2 component and service?
  12. Is there a type for “Class” in Typescript? And does “any” include it?
  13. Ionic – Horizontal scroll tab for Categories [duplicate]
  14. How to extend / inherit components?
  15. Difference between interfaces and classes in Typescript
  16. Generic email validator
  17. Detect changes in objects inside array in Angular2
  18. Lazy Loading BrowserModule has already been loaded
  19. Angular 2 input parameters on root directive [duplicate]
  20. Angular 2: How to use JavaScript Date Object with NgModel two way binding
  21. Unit testing click event in Angular
  22. want to show more data in another component when view in detail button is clicked (angular 6)
  23. Tracking scroll position and notifying other components about it
  24. Avoiding relative paths in Angular CLI
  25. ERROR in TypeError: Cannot read property ‘flags’ of undefined
  26. Angular 4: How to read data from Excel?
  27. Sanitize input in Angular2 [duplicate]
  28. What is pipe for in RxJS?
  29. How to throw error from RxJS map operator (angular)
  30. How to generate components in a specific folder with Angular CLI?

Leave a Comment