No, you will never get a NPE. This is because volatile
also has the memory-effect of introducing a happens-before relationship. In other words, it will prevent reordering of
a = one;
b = two;
The statements above, will not be re-ordered, and all threads will observe value one
for a
if b
already has value two
.
Here is a thread in which David Holmes explains this:
http://markmail.org/message/j7omtqqh6ypwshfv#query:+page:1+mid:34dnnukruu23ywzy+state:results
EDIT (response to the follow-up):
What Holmes is saying is, the compiler could in theory do a reorder if there were only thread A. However, there ARE other threads, and they CAN detect the reordering. That is why the compiler is NOT allowed to do that reordering. The java memory model requires the compiler specifically to make sure that no thread will ever detect such reordering.
But what if one is calling doIt() from
another thread than the one calling
setBothNonNull(…) ?
No, you will still NEVER have a NPE. volatile
semantics do impose inter-thread ordering. Meaning that, for all existing thread, assignment of one
happens before the assignment of two
.