What is the best way to implement this composite GetHashCode()

by

Like described by Jon Skeet in this SO answer, it is best practice to pick some prime numbers and multiply these with the single hash codes, then sum everything up.

public int GetHashCode()
{
    unchecked
    {
        int hash = 17;
        // Maybe nullity checks, if these are objects not primitives!
        hash = hash * 23 + Zoom.GetHashCode();
        hash = hash * 23 + X.GetHashCode();
        hash = hash * 23 + Y.GetHashCode();
        return hash;
    }
}

The problems with xor hashes are:

  • if X is equal to Y then your hash will be just Zoom, because then X ^ Y = X ^ X = 0 holds
  • xor is a symmetric operator, it will produce the exact same hashes for the objects [Zoom = 3, X = 5, Y = 7], [Zoom = 3, X = 7, Y = 5], [Zoom = 7, X = 5, Y = 3] etc.

These facts make the xor-method more likely to cause collisions.

In addition to Jons post, consider using a unchecked context, for explicitly ignoring overflows. Because like the MSDN says:

If neither checked nor unchecked is
used, a constant expression uses the
default overflow checking at compile
time, which is checked. Otherwise, if
the expression is non-constant, the
run-time overflow checking depends on
other factors such as compiler options
and environment configuration.

So while usually overflows will be unchecked, it may be that it fails somewhen in some environment or built with some compiler option. But in this case you want to explicitly not check these overflows.

Update:

By the way: someInt.GetHashCode() returns someInt. Like this, it is of course the fastest possible and a perfect hash distribution without a single collision. How else would you map an int to an int-hash? 🙂 So what I wanted to say: Your first approach:

return (Zoom + X + Y).GetHashCode();

and your second one:

return Zoom.GetHashCode() + X.GetHashCode() + Y.GetHashCode();

are exactly the same. You dont even have to call GetHashCode and both are very likely to have collisions. Maybe even worse than the xor method, if you very likely have small integer values for all three ints.

Update 2:

As I wrote in the comment to ChaosPandions post: If you just have those three int values, and X, Y and Zoom are relatively small numbers (smaller than 1000 or 10000) this one may be also a good hash generator: 

public int GetHashCode()
{
    return (X << 16) ^ (Y << 8) ^ Zoom;
}

It just distributes the bits in the hash value (example in big-endian for readability):

00000000 00000000 00000011 00110001    X = 817
00000000 00000000 00011011 11111010    Y = 7162
00000000 00000000 00000010 10010110    Zoom = 662

00000011 00110001 00000000 00000000    X << 16
00000000 00011011 11111010 00000000    Y << 8
00000000 00000000 00000010 10010110    Zoom

00000011 00101010 11111000 10010110    (X << 16) ^ (Y << 8) ^ Zoom

More Related Contents:

  1. Calculate MD5 checksum for a file
  2. Which cryptographic hash function should I choose?
  3. Is there an IDictionary implementation that, on missing key, returns the default value instead of throwing?
  4. How is GetHashCode() of C# string implemented?
  5. MD5 hash with salt for keeping password in DB in C#
  6. Getting hash of a list of strings regardless of order
  7. How do I run this code
  8. IOException: The process cannot access the file ‘file path’ because it is being used by another process
  9. Maximum number of threads in a .NET app?
  10. Is floating-point math consistent in C#? Can it be?
  11. What’s the difference between SortedList and SortedDictionary?
  12. What is the difference between “x is null” and “x == null”?
  13. .NET – What’s the best way to implement a “catch all exceptions handler”
  14. Multiple Parallel.ForEach loops in .Net
  15. How to put a task to sleep (or delay) in C# 4.0?
  16. Parsing Visual Studio Solution files
  17. How to create an Explorer-like folder browser control?
  18. Minimizing all open windows in C#
  19. Foo.cmd won’t output lines in process (on website)
  20. How to get MethodInfo of interface method, having implementing MethodInfo of class method?
  21. How to unsubscribe from an event which uses a lambda expression?
  22. Setting the initial directory of an SaveFileDialog?
  23. How to play a WPF Sound File resource
  24. Why Use Async/Await Over Normal Threading or Tasks?
  25. Programmatically installing MSI packages
  26. IP Address in a MaskedTextBox?
  27. Is there a fiber api in .net?
  28. Scientific notation when importing from Excel in .Net
  29. When should use Readonly and Get only properties
  30. How to Read an embedded resource as array of bytes without writing it to disk?

Leave a Comment