What is the proper way to rethrow an exception in C#? [duplicate]

by

You should always use the following syntax to rethrow an exception. Else you’ll stomp the stack trace:

throw;

If you print the trace resulting from throw ex, you’ll see that it ends on that statement and not at the real source of the exception.

Basically, it should be deemed a criminal offense to use throw ex.

If there is a need to rethrow an exception that comes from somewhere else (AggregateException, TargetInvocationException) or perhaps another thread, you also shouldn’t rethrow it directly. Rather there is the ExceptionDispatchInfo that preserves all the necessary information.

try
{
    methodInfo.Invoke(...);
}
catch (System.Reflection.TargetInvocationException e)
{
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Capture(e.InnerException).Throw();
    throw; // just to inform the compiler that the flow never leaves the block
}

More Related Contents:

  1. Catch multiple exceptions at once?
  2. Is there a difference between “throw” and “throw ex”?
  3. How to handle AccessViolationException
  4. WPF global exception handler [duplicate]
  5. How slow are .NET exceptions?
  6. Exception messages in English?
  7. How using try catch for exception handling is best practice
  8. How to rethrow InnerException without losing stack trace in C#?
  9. Cannot delete directory with Directory.Delete(path, true)
  10. TAP global exception handler
  11. Puzzling Enumerable.Cast InvalidCastException
  12. Can you catch a native exception in C# code?
  13. Avoiding first chance exception messages when the exception is safely handled
  14. Avoiding null reference exceptions
  15. User Activity Logging, Telemetry (and Variables in Global Exception Handlers)
  16. Why does a bad password cause “Padding is invalid and cannot be removed”?
  17. Is this a bad practice to catch a non-specific exception such as System.Exception? Why?
  18. InvalidProgramException / Common Language Runtime detected an invalid program
  19. What is ApplicationException for in .NET?
  20. How to prevent an exception in a background thread from terminating an application?
  21. Show line number in exception handling
  22. How to check for valid xml in string input before calling .LoadXml()
  23. Exception.Message vs Exception.ToString()
  24. Is there a built in .NET exception that indicates an illegal object state?
  25. Why Create Custom Exceptions? [closed]
  26. How do I determine the HResult for a System.IO.IOException?
  27. Catch Application Exceptions in a Windows Forms Application
  28. The ObjectContext instance has been disposed and can no longer be used for operations that require a connection [duplicate]
  29. Could not load file or assembly ‘System.Windows.Interactivity’ [duplicate]
  30. Which types of exception not to catch?

Leave a Comment