What is the safe way to fill multidimensional array using std::fill?

by

The simple way to initialize to 0 the array is in the definition:

char flags[26][80] = {};

If you want to use std::fill, or you want to reset the array, I find this a little better:

char flags[26][80];
std::fill( &flags[0][0], &flags[0][0] + sizeof(flags) /* / sizeof(flags[0][0]) */, 0 );

The fill expressed in terms of the array size will allow you to change the dimensions and keep the fill untouched. The sizeof(flags[0][0]) is 1 in your case (sizeof(char)==1), but you might want to leave it there in case you want to change the type at any point.

In this particular case (array of flags –integral type) I could even consider using memset even if it is the least safe alternative (this will break if the array type is changed to a non-pod type):

memset( &flags[0][0], 0, sizeof(flags) );

Note that in all three cases, the array sizes are typed only once, and the compiler deduces the rest. That is a little safer as it leaves less room for programmer errors (change the size in one place, forget it in the others).

EDIT: You have updated the code, and as it is it won’t compile as the array is private and you are trying to initialize it externally. Depending on whether your class is actually an aggregate (and want to keep it as such) or whether you want to add a constructor to the class you can use different approaches.

const std::size_t rows = 26;
const std::size_t cols = 80;
struct Aggregate {
   char array[rows][cols];
};
class Constructor {
public:
   Constructor() {
      std::fill( &array[0][0], &array[rows][0], 0 ); // [1]
      // memset( array, 0, sizeof(array) );
   }
private:
   char array[rows][cols];
};
int main() {
   Aggregate a = {};
   Constructor b;
}

Even if the array is meant to be public, using a constructor might be a better approach as it will guarantee that the array is properly initialized in all instances of the class, while the external initialization depends on user code not forgetting to set the initial values.

[1] As @Oli Charlesworth mentioned in a comment, using constants is a different solution to the problem of having to state (and keep in synch) the sizes in more than one place. I have used that approach here with a yet different combination: a pointer to the first byte outside of the bidimensional array can be obtained by requesting the address of the first column one row beyond the bidimensional array. I have used this approach just to show that it can be done, but it is not any better than others like &array[0][0]+(rows*cols)

More Related Contents:

  1. How to access 1 element in 2D dynamic array in C++
  2. C++ – Find numbers between first and last negative numbers in Array
  3. Absolute Distinct Numbers
  4. How do I take values from text file and input into a 2D array? c++
  5. How do I use arrays in C++?
  6. How do I declare a 2d array in C++ using new?
  7. Passing a 2D array to a C++ function
  8. How to pass a multidimensional array to a function in C and C++
  9. May I treat a 2D array as a contiguous 1D array?
  10. How do I best handle dynamic multi-dimensional arrays in C/C++?
  11. A pointer to 2d array
  12. Statically declared 2-D array C++ as data member of a class [duplicate]
  13. How to initialize 3D array in C++
  14. The intersection of two sorted arrays
  15. Searching in a sorted and rotated array
  16. How to print 2D Arrays in C++?
  17. C++ 2 dimensional array with variable size rows
  18. In C/C++, is char* arrayName[][] a pointer to a pointer to a pointer OR a pointer to a pointer?
  19. Setting pointer to arbitrary dimension array?
  20. C / C++ How to copy a multidimensional char array without nested loops?
  21. Mapping elements in 2D upper triangle and lower triangle to linear structure
  22. sizeof works unusual at c++ after array creation [duplicate]
  23. How to find out how many bits are set (equal 1) in the product of two integers [closed]
  24. Accessing an array out of bounds gives no error, why?
  25. Image Processing: Algorithm Improvement for ‘Coca-Cola Can’ Recognition
  26. Fast ceiling of an integer division in C / C++
  27. Sort a 2D array in C++ using built in functions(or any other method)?
  28. Is there a function to copy an array in C/C++?
  29. c++ sort with structs
  30. C++: Fastest method to check if all array elements are equal

Leave a Comment