What’s preferred pattern for reading lines from a file in C++?

by 
while (std::getline(fs, line))
{}

This is not only correct but preferable also because it is idiomatic.

I assume in the first case, you’re not checking fs after std::getline() as if(!fs) break; or something equivalent. Because if you don’t do so, then the first case is completely wrong. Or if you do that, then second one is still preferable as its more concise and clear in logic.

The function good() should be used after you made an attempt to read from the stream; its used to check if the attempt was successful. In your first case, you don’t do so. After std::getline(), you assume that the read was successful, without even checking what fs.good() returns. Also, you seem to assume that if fs.good() returns true, std::getline would successfully read a line from the stream. You’re going exactly in the opposite direction: the fact is that, if std::getline successfully reads a line from the stream, then fs.good() would return true.

The documentation at cplusplus says about good() that,

The function returns true if none of the stream’s error flags (eofbit, failbit and badbit) are set.

That is, when you attempt to read data from an input stream, and if the attempt was failure, only then a failure flag is set and good() returns false as an indication of the failure.

If you want to limit the scope of line variable to inside the loop only, then you can write a for loop as:

for(std::string line; std::getline(fs, line); )
{
   //use 'line'
}

Note: this solution came to my mind after reading @john’s solution, but I think its better than his version.

Read a detail explanation here why the second one is preferable and idiomatic:

Or read this nicely written blog by @Jerry Coffin:

More Related Contents:

  1. How to shift characters to ASCII values in a file based on user input c++ [closed]
  2. How do I take values from text file and input into a 2D array? c++
  3. Read file line by line using ifstream in C++
  4. Read whole ASCII file into C++ std::string [duplicate]
  5. How do I read an entire file into a std::string in C++?
  6. Copy a file in a sane, safe and efficient way
  7. Difference between files written in binary and text mode
  8. mmap() vs. reading blocks
  9. Getting a FILE* from a std::fstream
  10. How do I make my program watch for file modification in C++?
  11. Read file-contents into a string in C++ [duplicate]
  12. Elegant ways to count the frequency of words in a file
  13. How to read a binary file into a vector of unsigned chars
  14. What is the most elegant way to read a text file with c++?
  15. Why don’t the std::fstream classes take a std::string?
  16. How to signify no more input for string ss in the loop while (cin >> ss)
  17. What is the Fastest Method for High Performance Sequential File I/O in C++?
  18. checking for eof in string::getline
  19. C++ ifstream failbit and badbit
  20. How to read a file into vector in C++?
  21. Reading and writing a std::vector into a file correctly
  22. C++/Win32: How to wait for a pending delete to complete
  23. Read file names from a directory
  24. fstream won’t create a file [duplicate]
  25. How to check if a file is gzip compressed?
  26. How to write a Float Mat to a file in OpenCV
  27. How to check if a file has been opened by another application in C++?
  28. How to count lines of a file in C++?
  29. Reading files larger than 4GB using c++ stl
  30. Performance Difference Between C and C++ Style File IO

Leave a Comment