What’s the right way to overload operator== for a class hierarchy?

by

For this sort of hierarchy I would definitely follow the Scott Meyer’s Effective C++ advice and avoid having any concrete base classes. You appear to be doing this in any case.

I would implement operator== as a free functions, probably friends, only for the concrete leaf-node class types.

If the base class has to have data members, then I would provide a (probably protected) non-virtual helper function in the base class (isEqual, say) which the derived classes’ operator== could use.

E.g.

bool operator==(const B& lhs, const B& rhs)
{
    return lhs.isEqual( rhs ) && lhs.bar == rhs.bar;
}

By avoiding having an operator== that works on abstract base classes and keeping compare functions protected, you don’t ever get accidentally fallbacks in client code where only the base part of two differently typed objects are compared.

I’m not sure whether I’d implement a virtual compare function with a dynamic_cast, I would be reluctant to do this but if there was a proven need for it I would probably go with a pure virtual function in the base class (not operator==) which was then overriden in the concrete derived classes as something like this, using the operator== for the derived class.

bool B::pubIsEqual( const A& rhs ) const
{
    const B* b = dynamic_cast< const B* >( &rhs );
    return b != NULL && *this == *b;
}

More Related Contents:

  1. What are the basic rules and idioms for operator overloading?
  2. Operator[][] overload
  3. How to properly overload the
  4. Overloading member access operators ->, .*
  5. Why override operator()?
  6. How to code a modulo (%) operator in C/C++/Obj-C that handles negative numbers
  7. Why istream object can be used as a bool expression?
  8. Why can’t you overload the ‘.’ operator in C++?
  9. Why should the assignment operator return a reference to the object?
  10. How can I reliably get an object’s address when operator& is overloaded?
  11. Why cannot a non-member function be used for overloading the assignment operator?
  12. What legitimate reasons exist to overload the unary operator&?
  13. Calling a const function rather than its non-const version
  14. Operator overloading outside class [duplicate]
  15. Is there actually a reason why overloaded && and || don’t short circuit?
  16. Using the less than comparison operator for strings
  17. C++ overloading array operator
  18. Const and Non-Const Operator Overloading
  19. Overloading assignment operator in C++
  20. ‘friend’ functions and
  21. Can’t Overload operator
  22. How do we declare a friend function with a class template into .h file and define them into a .cpp file (not all in one header file)?
  23. How do I call the original “operator new” if I have overloaded it?
  24. Operator overload which permits capturing with rvalue but not assigning to
  25. C++ why the assignment operator should return a const ref in order to avoid (a=b)=c
  26. Why default three-way operator (spaceship ) generates equality operator (==) and user define three-way operator not?
  27. operator
  28. How arrow-> operator overloading works internally in c++?
  29. How to differentiate (when overloading) between prefix and postfix forms of operator++? (C++)
  30. std::getline() reads carriage return \r into the string, how to avoid that?

Leave a Comment