When is a function too long? [closed]

by

Here is a list of red-flags (in no particular order) that could indicate that a function is too long:

  1. Deeply nested control structures: e.g. for-loops 3 levels deep or even just 2 levels deep with nested if-statements that have complex conditions.

  2. Too many state-defining parameters: By state-defining parameter, I mean a function parameter that guarantees a particular execution path through the function. Get too many of these type of parameters and you have a combinatorial explosion of execution paths (this usually happens in tandem with #1).

  3. Logic that is duplicated in other methods: poor code re-use is a huge contributor to monolithic procedural code. A lot of such logic duplication can be very subtle, but once re-factored, the end result can be a far more elegant design.

  4. Excessive inter-class coupling: this lack of proper encapsulation results in functions being concerned with intimate characteristics of other classes, hence lengthening them.

  5. Unnecessary overhead: Comments that point out the obvious, deeply nested classes, superfluous getters and setters for private nested class variables, and unusually long function/variable names can all create syntactic noise within related functions that will ultimately increase their length.

  6. Your massive developer-grade display isn’t big enough to display it: Actually, displays of today are big enough that a function that is anywhere close to its height is probably way too long. But, if it is larger, this is a smoking gun that something is wrong.

  7. You can’t immediately determine the function’s purpose: Furthermore, once you actually do determine its purpose, if you can’t summarize this purpose in a single sentence or happen to have a tremendous headache, this should be a clue.

In conclusion, monolithic functions can have far-reaching consequences and are often a symptom of major design deficiencies. Whenever I encounter code that is an absolute joy to read, it’s elegance is immediately apparent. And guess what: the functions are often very short in length.

More Related Contents:

  1. How many lines of code should a function/procedure/method have? [duplicate]
  2. Difference between method and function in Scala
  3. Understanding how recursive functions work
  4. What is the difference between a ‘closure’ and a ‘lambda’?
  5. Value receiver vs. pointer receiver
  6. How to explain callbacks in plain english? How are they different from calling one function from another function?
  7. Define table and column names as arguments in a plpgsql function?
  8. Correct use of modules, subroutines and functions in Fortran
  9. Computing the cross product of two vectors in Fortran 90
  10. Committing transactions while executing a postgreql Function
  11. Non exhaustive pattern in function in GHCi
  12. How is the square root function implemented? [closed]
  13. How to write a Rust function that takes an iterator?
  14. Static vs class functions/variables in Swift classes?
  15. Whats the difference of functions and methods in Go?
  16. R: 2 functions with the same name in 2 different packages
  17. Return a list from the function using OUT parameter
  18. How many constructor arguments is too many? [closed]
  19. Define a recursive function within a function in Go
  20. “Identifier Expected” or “Invalid Prototype” when implementing a scripted constant in Inno Setup
  21. Return value from a VBScript function
  22. Two ways of defining functions in Scala. What is the difference?
  23. Kotlin: How can I create a “static” inheritable function?
  24. use onedit() trigger on a specific sheet within google scripts for google sheets
  25. No function matches the given name and argument types
  26. How can I generate a list of function dependencies in MATLAB?
  27. MsgBox “” vs MsgBox() in VBScript
  28. MATLAB error: Undefined function or method X for input arguments of type ‘double’ [duplicate]
  29. Bodiless function in Golang
  30. How can we force naming of parameters when calling a function?

Leave a Comment