Why do we cast return value of malloc? [duplicate]

by

No need to cast return value of malloc as its return type is void*.

Can someone explain why do some programmers use (char *) in front of the malloc?

They are doing wrong (most probably) by casting it (in good programmers opinion).

As wiki says:

malloc returns a void pointer (void *), which indicates that it is a pointer to a region of unknown data type. The use of casting is required in C++ due to the strong type system, whereas this is not the case in C1. The lack of a specific pointer type returned from malloc is type-unsafe behavior according to some programmers: malloc allocates based on byte count but not on type. This is different from the C++ new operator that returns a pointer whose type relies on the operand.
One may “cast” this pointer to a specific type:

int *ptr;
ptr = malloc(10 * sizeof (*ptr));               /* without a cast */
ptr = (int *)malloc(10 * sizeof (*ptr));        /* with a cast */
ptr = reinterpret_cast<int *>(malloc(10 * sizeof (*ptr))); /* with a cast, for C++ */

There are advantages and disadvantages to performing such a cast.

Advantages to casting:

  • Including the cast allows a program or function to compile as C++.
  • The cast allows for pre-1989 versions of malloc that originally returned a char *.
  • Casting can help the developer identify inconsistencies in type sizing should the destination pointer type change, particularly if the pointer is declared far from the malloc() call.

Disadvantages to casting:

  • Under the ANSI C standard, the cast is redundant.
  • Adding the cast may mask failure to include the header stdlib.h, in which the prototype for malloc is found. In the absence of a prototype for malloc, the standard requires that the C compiler assume malloc returns an int. If there is no cast, a warning is issued when this integer is assigned to the pointer; however, with the cast, this warning is not produced, hiding a bug. On certain architectures and data models (such as LP64 on 64-bit systems, where long and pointers are 64-bit and int is 32-bit), this error can actually result in undefined behavior, as the implicitly declared malloc returns a 32-bit value whereas the actually defined function returns a 64-bit value. Depending on calling conventions and memory layout, this may result in stack smashing. This issue is less likely to go unnoticed in modern compilers, as they uniformly produce warnings that an undeclared function has been used, so a warning will still appear. For example, GCC’s default behavior is to show a warning that reads “incompatible implicit declaration of built-in function” regardless of whether the cast is present or not.
  • If the type of the pointer is changed, one must fix all code lines where malloc was called and cast (unless it was cast to a typedef).

1. Emphases are mine.

More Related Contents:

  1. What REALLY happens when you don’t free after malloc before program termination?
  2. How do I correctly set up, access, and free a multidimensional array in C?
  3. Why is the use of alloca() not considered good practice?
  4. Why malloc+memset is slower than calloc?
  5. C Programming: malloc() inside another function
  6. How do free and malloc work in C?
  7. Setting variable to NULL after free
  8. Difference between array type and array allocated with malloc
  9. Is malloc thread-safe?
  10. Create a wrapper function for malloc and free in C
  11. Writing to pointer out of bounds after malloc() not causing error
  12. What does malloc(0) return? [duplicate]
  13. Why do I get a C malloc assertion failure?
  14. C – allocating a matrix in a function
  15. Explain this implementation of malloc from the K&R book
  16. Use of cudamalloc(). Why the double pointer?
  17. Find malloc() array length in C? [duplicate]
  18. How to determine the size of an allocated C buffer? [duplicate]
  19. Why do I get different results when I dereference a pointer after freeing it?
  20. Malloc vs custom allocator: Malloc has a lot of overhead. Why?
  21. Why do I get a warning every time I use malloc?
  22. How to get memory block length after malloc?
  23. An alternative for the deprecated __malloc_hook functionality of glibc
  24. Heap allocate a 2D array (not array of pointers)
  25. Is freeing allocated memory needed when exiting a program in C
  26. C – freeing structs
  27. Malloc function (dynamic memory allocation) resulting in an error when it is used globally
  28. Code for malloc and free
  29. checking that `malloc` succeeded in C
  30. Is typecast required in malloc? [duplicate]

Leave a Comment