why does my compare method throw exception — Comparison method violates its general contract!

by

I suspect the problem occurs when neither value is sponsored. That will return 1 whichever way you call it, i.e.

x1.compare(x2) == 1

x2.compare(x1) == 1

That’s invalid.

I suggest you change this:

object1.getSponsored() && object2.getSponsored()

to

object1.getSponsored() == object2.getSponsored()

in both places. I would probably actually extract this out a method with this signature somewhere:

public static int compare(boolean x, boolean y)

and then call it like this:

public int compare(SRE object1, SRE object2) {
    return BooleanHelper.compare(object1.getSponsored(), object2.getSponsored());
}

That will make the code clearer, IMO.

More Related Contents:

  1. Android-java- How to sort a list of objects by a certain value within the object
  2. java.lang.IllegalStateException: Only fullscreen opaque activities can request orientation
  3. android: changing option menu items programmatically
  4. Android Retrofit Parameterized @Headers
  5. How to set unit for Paint.setTextSize()
  6. Exception in thread “main” java.lang.NoClassDefFoundError: junit/textui/ResultPrinter
  7. Can Activity.getIntent() ever return null?
  8. How to show a notification without a sound java
  9. How to test if a JSONObject is null or doesn’t exist
  10. How to get line count of textview before rendering?
  11. How to get the Context from anywhere? [duplicate]
  12. Android WebView File Upload
  13. How to convert JSONArray to List with Gson?
  14. Using Sockets to send and receive data
  15. Transparent status bar – before Android 4.4 (KitKat)
  16. Asynctask: pass two or more values from doInBackground to onPostExecute
  17. Can’t Disable Offline Data In Firestore
  18. When may we need to use runOnUiThread in android application?
  19. Java Static Variable becomes null [duplicate]
  20. stringByEvaluatingJavascriptFromString (iOS method, what is Android equivalent?)
  21. java.lang.SecurityException: attempting to read gservices without permission
  22. What exactly does Android’s @hide annotation do?
  23. How to execute web request in its own thread?
  24. Command failed: gradlew.bat installDebug
  25. Android java.lang.NoClassDefFoundError: org.jsoup.Jsoup
  26. How to add rectangles on top of existing rectangle in canvas
  27. C++ ifstream.getline() significantly slower than Java’s BufferedReader.readLine()?
  28. Code for download video from Youtube on Java, Android
  29. How to save and retrieve Date in SharedPreferences
  30. After upload a file in Android Firebase Storage how get the file download Url? getDownloadUrl() not working

Leave a Comment