Why is strdup considered to be evil

by

Two reasons I can think of:

  1. It’s not strictly ANSI C, but rather POSIX. Consequently, some compilers (e.g. MSVC) discourage use (MSVC prefers _strdup), and technically the C standard could define its own strdup with different semantics since str is a reserved prefix. So, there are some potential portability concerns with its use.
  2. It hides its memory allocation. Most other str functions don’t allocate memory, so users might be misled (as you say) into believing the returned string doesn’t need to be freed.

But, aside from these points, I think that careful use of strdup is justified, as it can reduce code duplication and provides a nice implementation for common idioms (such as strdup("constant string") to get a mutable, returnable copy of a literal string).

More Related Contents:

  1. What does %d mean? Why d and not another letter? [closed]
  2. C Password Log giving me errors
  3. char c[]=”Albus”; printf(“%c”, c); [closed]
  4. Why do I get a segmentation fault when writing to a “char *s” initialized with a string literal, but not “char s[]”?
  5. How should character arrays be used as strings?
  6. C – split string into an array of strings
  7. Why do I first have to strcpy() before strcat()?
  8. C Strings Comparison with Equal Sign
  9. What are null-terminated strings?
  10. Why gets() is deprecated? [duplicate]
  11. Is it possible to print out only a certain section of a C-string, without making a separate substring?
  12. Implementation of strcmp
  13. String termination – char c=0 vs char c=’\0′
  14. Is sprintf(buffer, “%s […]”, buffer, […]) safe?
  15. expected ‘void (**)(void *, const char *)’ but argument is of type ‘void (*)(void *, const char *)
  16. Why does reading into a string buffer with scanf work both with and without the ampersand (&)?
  17. Is NULL always zero in C?
  18. gcc, strict-aliasing, and horror stories [closed]
  19. Matrix multiplication: Small difference in matrix size, large difference in timings
  20. Meaning of “referencing” and “dereferencing” in C
  21. How do you get a directory listing in C?
  22. How to work on a sub-matrix in a matrix by pointer?
  23. When to use static keyword before global variables?
  24. How to use SO_KEEPALIVE option properly to detect that the client at the other end is down?
  25. strdup() function
  26. How to get ip address from sock structure in c?
  27. What does \x mean in C/C++?
  28. sending EOF to stdin in Clion IDE
  29. How to use sched_getaffinity and sched_setaffinity in Linux from C?
  30. How to declare a structure in a header that is to be used by multiple files in c?

Leave a Comment