Why LiveData observer is being triggered twice for a newly attached observer

by

I have introduced just one change in your code:

noteViewModel = ViewModelProviders.of(this).get(NoteViewModel.class);

instead of:

noteViewModel = ViewModelProviders.of(getActivity()).get(NoteViewModel.class);

in Fragment‘s onCreate(Bundle) methods. And now it works seamlessly.

In your version you obtained a reference of NoteViewModel common to both Fragments (from Activity). ViewModel had Observer registered in previous Fragment, I think. Therefore LiveData kept reference to both Observer‘s (in MainFragment and TrashFragment) and called both values.

So I guess the conclusion might be, that you should obtain ViewModel from ViewModelProviders from:

  • Fragment in Fragment
  • Activity in Activity

Btw.

noteViewModel.getTrashedNotesLiveData().removeObservers(this);

is not necessary in Fragments, however I would advise putting it in onStop.

More Related Contents:

  1. LiveData prevent receive the last value when start observing
  2. Room – LiveData observer does not trigger when database is updated
  3. Why there’s a separate MutableLiveData subclass of LiveData?
  4. How to combine two live data one after the other?
  5. What is AndroidX?
  6. Sharing data between fragments using new architecture component ViewModel
  7. How to clear navigation Stack after navigating to another fragment in Android
  8. IllegalStateException: Link does not have a NavController set
  9. Android Persistence room: “Cannot figure out how to read this field from a cursor”
  10. LiveData update on object field change
  11. AndroidViewModel vs ViewModel
  12. Android Room: Insert relation entities using Room
  13. Notify Observer when item is added to List of LiveData
  14. Room Persistence: Error:Entities and Pojos must have a usable public constructor
  15. Android Jetpack Navigation, BottomNavigationView with Youtube or Instagram like proper back navigation (fragment back stack)?
  16. Difference of setValue() & postValue() in MutableLiveData
  17. Cannot create an instance of class ViewModel
  18. ViewPager with Navigation architecture components [duplicate]
  19. How can I represent a “many to many” relation with Android Room when column names are same?
  20. Return type for Android Room joins
  21. ViewModelProviders is deprecated in 1.1.0
  22. Room : LiveData from Dao will trigger Observer.onChanged on every Update, even if the LiveData value has no change
  23. LiveData remove Observer after first callback
  24. How I can retrieve current fragment in NavHostFragment?
  25. How to implement a ViewPager with BottomNavigationView using new Navigation Architecture Component?
  26. Observe LiveData from foreground service
  27. Navigation Architecture Component- Passing argument data to the startDestination
  28. Backup Room database
  29. Programmatically obtain the phone number of the Android phone
  30. Trigger mediascanner on specific path (folder), how to?

Leave a Comment