Why should exec() and eval() be avoided?

by

There are often clearer, more direct ways to get the same effect. If you build a complex string and pass it to exec, the code is difficult to follow, and difficult to test.

Example: I wrote code that read in string keys and values and set corresponding fields in an object. It looked like this: 

for key, val in values:
    fieldName = valueToFieldName[key]
    fieldType = fieldNameToType[fieldName]
    if fieldType is int:
        s="object.%s = int(%s)" % (fieldName, fieldType) 
    #Many clauses like this...

exec(s)

That code isn’t too terrible for simple cases, but as new types cropped up it got more and more complex. When there were bugs they always triggered on the call to exec, so stack traces didn’t help me find them. Eventually I switched to a slightly longer, less clever version that set each field explicitly.

The first rule of code clarity is that each line of your code should be easy to understand by looking only at the lines near it. This is why goto and global variables are discouraged. exec and eval make it easy to break this rule badly.

More Related Contents:

  1. Why is “1000000000000000 in range(1000000000000001)” so fast in Python 3?
  2. Count the frequency that a value occurs in a dataframe column
  3. How to find list intersection?
  4. How accurate is python’s time.sleep()?
  5. Using sudo with Python script
  6. Plotting in a non-blocking way with Matplotlib
  7. Deleting multiple elements from a list
  8. Check if a file is not open nor being used by another process
  9. Python: Open file in zip without temporarily extracting it
  10. How should I use the Optional type hint?
  11. join two lists of dictionaries on a single key
  12. shuffle string in python
  13. OpenCV: “[ WARN:0] terminating async callback” when attempting to take a picture
  14. Spark add new column to dataframe with value from previous row
  15. Comparing floats in a pandas column
  16. How do I split a string into several columns in a dataframe with pandas Python?
  17. Python – Converting XLSX to PDF
  18. OSError 38 [Errno 38] with multiprocessing
  19. Is it possible to not return anything from a function in python?
  20. Flattening a list recursively [duplicate]
  21. Better way to shuffle two numpy arrays in unison
  22. Environment Variables when script run by cron
  23. How to use logging.getLogger(__name__) in multiple modules
  24. Image is not displaying in Google Colab while using imshow()
  25. How to count top 10 most common values in a dict in python
  26. Most Efficient Way to Find Whether a Large List Contains a Specific String (Python)
  27. ‘pip setup.py bdist_wheel’ no longer builds forced non-pure wheels
  28. pandas extract year from datetime: df[‘year’] = df[‘date’].year is not working
  29. Psycopg2, Postgresql, Python: Fastest way to bulk-insert
  30. Does Python GC deal with reference-cycles like this?

Leave a Comment