Are empty interfaces code smell? [closed]

by

Although it seems there exists a design pattern (a lot have mentioned “marker interface” now) for that use case, i believe that the usage of such a practice is an indication of a code smell (most of the time at least).

As @V4Vendetta posted, there is a static analysis rule that targets this:
http://msdn.microsoft.com/en-us/library/ms182128(v=VS.100).aspx

If your design includes empty interfaces that types are expected to implement, you are probably using an interface as a marker or a way to identify a group of types. If this identification will occur at run time, the correct way to accomplish this is to use a custom attribute. Use the presence or absence of the attribute, or the properties of the attribute, to identify the target types. If the identification must occur at compile time, then it is acceptable to use an empty interface.

This is the quoted MSDN recommendation:

Remove the interface or add members to it. If the empty interface is being used to label a set of types, replace the interface with a custom attribute.

This also reflects the Critique section of the already posted wikipedia link.

A major problem with marker interfaces is that an interface defines a contract for implementing classes, and that contract is inherited by all subclasses. This means that you cannot “unimplement” a marker. In the example given, if you create a subclass that you do not want to serialize (perhaps because it depends on transient state), you must resort to explicitly throwing NotSerializableException (per ObjectOutputStream docs).

More Related Contents:

  1. C# Singleton Form pattern, how to run 2 and more forms? [closed]
  2. Why and How to avoid Event Handler memory leaks?
  3. C# Object Pooling Pattern implementation
  4. C# producer/consumer
  5. Why does C# not provide the C++ style ‘friend’ keyword? [closed]
  6. Thread Safe C# Singleton Pattern
  7. How to implement Generic Repository Design Pattern with Dapper?
  8. Large Switch statements: Bad OOP?
  9. Double dispatch in C#?
  10. Model-View-Presenter in WinForms
  11. Singleton by Jon Skeet clarification
  12. Design pattern for handling multiple message types
  13. Merge multiple Lists into one List with LINQ
  14. What is difference between MVC, MVP & MVVM design pattern in terms of coding c#
  15. How to implement SOLID principles into an existing project
  16. MVVM show new window from VM when seperated projects
  17. Singleton httpclient vs creating new httpclient request
  18. Raise Events in .NET on the main UI thread
  19. getting db connection through singleton class
  20. Using a Strategy and Factory Pattern with Dependency Injection
  21. DDD Approach to Access External Information
  22. A way of casting a base type to a derived type
  23. Repository Pattern Step by Step Explanation [closed]
  24. Factory pattern in C#: How to ensure an object instance can only be created by a factory class?
  25. How would you implement a “trait” design-pattern in C#?
  26. Entities VS Domain Models VS View Models
  27. Need an ASP.NET MVC long running process with user feedback
  28. Non-virtual interface design pattern in C#/C++
  29. View Models and dependency injection
  30. Best practices for multi-form applications to show and hide forms? [closed]

Leave a Comment