Awaiting Asynchronous function inside FormClosing Event

by

The best answer, in my opinion, is to cancel the Form from closing. Always. Cancel it, display your dialog however you want, and once the user is done with the dialog, programatically close the Form.

Here’s what I do:

async void Window_Closing(object sender, CancelEventArgs args)
{
    var w = (Window)sender;
    var h = (ObjectViewModelHost)w.Content;
    var v = h.ViewModel;

    if (v != null &&
        v.IsDirty)
    {
        args.Cancel = true;
        w.IsEnabled = false;

        // caller returns and window stays open
        await Task.Yield();

        var c = await interaction.ConfirmAsync(
            "Close",
            "You have unsaved changes in this window. If you exit they will be discarded.",
            w);
        if (c)
            w.Close();

        // doesn't matter if it's closed
        w.IsEnabled = true;
    }
}

It is important to note the call to await Task.Yield(). It would not be necessary if the async method being called always executed asynchronously. However, if the method has any synchronous paths (ie. null-check and return, etc…) the Window_Closing event will never finish execution and the call to w.Close() will throw an exception.

More Related Contents:

  1. What is the purpose of “return await” in C#?
  2. Is it possible to await an event instead of another async method?
  3. Async/await vs BackgroundWorker
  4. Awaiting multiple Tasks with different results
  5. What’s the difference between Task.Start/Wait and Async/Await?
  6. Using ‘async’ in a console application in C# [duplicate]
  7. Do you have to put Task.Run in a method to make it async?
  8. awaitable Task based queue
  9. Brief explanation of Async/Await in .Net 4.5
  10. Await operator can only be used within an Async method [duplicate]
  11. Is async HttpClient from .Net 4.5 a bad choice for intensive load applications?
  12. How to ‘await’ raising an EventHandler event
  13. Task.Yield – real usages?
  14. HttpClient.GetAsync with network credentials
  15. What’s the difference between InvokeAsync and BeginInvoke for WPF Dispatcher
  16. Using async / await with DataReader ? ( without middle buffers!)
  17. Should I avoid ‘async void’ event handlers?
  18. How can I call an async method in Main?
  19. How to protect resources that may be used in a multi-threaded or async environment?
  20. A reusable pattern to convert event into task
  21. Why would I bother to use Task.ConfigureAwait(continueOnCapturedContext: false);
  22. ConfigureAwait pushes the continuation to a pool thread
  23. How can I prevent synchronous continuations on a Task?
  24. Correct way to get the CoreDispatcher in a Windows Store app
  25. Async action filter in MVC 4
  26. Async/Await – is it *concurrent*?
  27. Converting a WebClient method to async / await
  28. How to throttle multiple asynchronous tasks?
  29. How do I get a return value from Task.WaitAll() in a console app?
  30. call async method without await #2

Leave a Comment