Best practice: PHP Magic Methods __set and __get [duplicate]

by

I have been exactly in your case in the past. And I went for magic methods.

This was a mistake, the last part of your question says it all :

  • this is slower (than getters/setters)
  • there is no auto-completion (and this is a major problem actually), and type management by the IDE for refactoring and code-browsing (under Zend Studio/PhpStorm this can be handled with the @property phpdoc annotation but that requires to maintain them: quite a pain)
  • the documentation (phpdoc) doesn’t match how your code is supposed to be used, and looking at your class doesn’t bring much answers as well. This is confusing.
  • added after edit: having getters for properties is more consistent with “real” methods where getXXX() is not only returning a private property but doing real logic. You have the same naming. For example you have $user->getName() (returns private property) and $user->getToken($key) (computed). The day your getter gets more than a getter and needs to do some logic, everything is still consistent.

Finally, and this is the biggest problem IMO : this is magic. And magic is very very bad, because you have to know how the magic works to use it properly. That’s a problem I’ve met in a team: everybody has to understand the magic, not just you.

Getters and setters are a pain to write (I hate them) but they are worth it.

More Related Contents:

  1. PHP __get and __set magic methods
  2. PHP – Indirect modification of overloaded property
  3. How to document magic (_call and _callStatic) methods for IDEs
  4. If number have inside number string [closed]
  5. How to execute a line of code once?
  6. php – Should I call exit() after calling Location: header?
  7. How can I update code that uses the deprecated each() function?
  8. json_encode() escaping forward slashes
  9. WooCommerce action hooks and overriding templates
  10. What is the “->” PHP operator called? [closed]
  11. How can I add a PHP page to WordPress?
  12. Laravel Check If Related Model Exists
  13. Sort and display directory list alphabetically using opendir() in php
  14. Reconstruct / get source code of a PHP function
  15. Explode a string to associative array without using loops? [duplicate]
  16. What does ${ } mean in PHP syntax?
  17. PHP PDO and MySQLi [duplicate]
  18. PHP printed boolean value is empty, why?
  19. why is $_REQUEST empty
  20. How to set cron job URL for CodeIgniter?
  21. Error 1148 MySQL The used command is not allowed with this MySQL version
  22. Is there an equivalent for var_dump (PHP) in Javascript?
  23. How to define a Laravel route with a parameter that contains a slash character
  24. php/symfony/doctrine memory leak?
  25. is_null($x) vs $x === null in PHP [duplicate]
  26. Detect if cookies are enabled in PHP
  27. Replacing \r\n with PHP
  28. Limit download speed using PHP
  29. Check if links are broken in php
  30. Convert delimited string into array key path and assign value

Leave a Comment