Binding ComboBox SelectedItem using MVVM

by

You seem to be unnecessarily setting properties on your ComboBox. You can remove the DisplayMemberPath and SelectedValuePath properties which have different uses. It might be an idea for you to take a look at the Difference between SelectedItem, SelectedValue and SelectedValuePath post here for an explanation of these properties. Try this:

<ComboBox Name="cbxSalesPeriods"
    ItemsSource="{Binding SalesPeriods}"
    SelectedItem="{Binding SelectedSalesPeriod}"
    IsSynchronizedWithCurrentItem="True"/>

Furthermore, it is pointless using your displayPeriod property, as the WPF Framework would call the ToString method automatically for objects that it needs to display that don’t have a DataTemplate set up for them explicitly.

UPDATE >>>

As I can’t see all of your code, I cannot tell you what you are doing wrong. Instead, all I can do is to provide you with a complete working example of how to achieve what you want. I’ve removed the pointless displayPeriod property and also your SalesPeriodVO property from your class as I know nothing about it… maybe that is the cause of your problem??. Try this:

public class SalesPeriodV
{
    private int month, year;

    public int Year
    {
        get { return year; }
        set
        {
            if (year != value)
            {
                year = value;
                NotifyPropertyChanged("Year");
            }
        }
    }

    public int Month
    {
        get { return month; }
        set
        {
            if (month != value)
            {
                month = value;
                NotifyPropertyChanged("Month");
            }
        }
    }

    public override string ToString()
    {
        return String.Format("{0:D2}.{1}", Month, Year);
    }

    public virtual event PropertyChangedEventHandler PropertyChanged;
    protected virtual void NotifyPropertyChanged(params string[] propertyNames)
    {
        if (PropertyChanged != null)
        {
            foreach (string propertyName in propertyNames) PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
            PropertyChanged(this, new PropertyChangedEventArgs("HasError"));
        }
    }
}

Then I added two properties into the view model:

private ObservableCollection<SalesPeriodV> salesPeriods = new ObservableCollection<SalesPeriodV>();
public ObservableCollection<SalesPeriodV> SalesPeriods
{
    get { return salesPeriods; }
    set { salesPeriods = value; NotifyPropertyChanged("SalesPeriods"); }
}
private SalesPeriodV selectedItem = new SalesPeriodV();
public SalesPeriodV SelectedItem
{
    get { return selectedItem; }
    set { selectedItem = value; NotifyPropertyChanged("SelectedItem"); }
}

Then initialised the collection with your values:

SalesPeriods.Add(new SalesPeriodV() { Month = 3, Year = 2013 } );
SalesPeriods.Add(new SalesPeriodV() { Month = 4, Year = 2013 } );

And then data bound only these two properties to a ComboBox:

<ComboBox ItemsSource="{Binding SalesPeriods}" SelectedItem="{Binding SelectedItem}" />

That’s it… that’s all you need for a perfectly working example. You should see that the display of the items comes from the ToString method without your displayPeriod property. Hopefully, you can work out your mistakes from this code example.

More Related Contents:

  1. Binding a WPF ComboBox to a custom list
  2. Why RelayCommand
  3. WPF: Binding a ContextMenu to an MVVM Command
  4. MVVM: Binding radio buttons to a view model?
  5. Cannot find source for binding with reference ‘RelativeSource FindAncestor’ [duplicate]
  6. Should I bind to ICollectionView or ObservableCollection
  7. WPF: How to bind a command to the ListBoxItem using MVVM?
  8. Can I somehow temporarily disable WPF data binding changes?
  9. WPF TwoWay Binding to a static class Property
  10. Problems with binding to Window Height and Width
  11. Binding Image.Source to String in WPF?
  12. WPF MVVM: how to bind GridViewColumn to ViewModel-Collection?
  13. WPF + MVVM + RadioButton : How to handle binding with single property?
  14. WPF MVVM navigate views
  15. WPF Binding UI events to commands in ViewModel
  16. Richtextbox wpf binding
  17. How can you clone a WPF object?
  18. ReSharper WPF error: “Cannot resolve symbol “MyVariable” due to unknown DataContext”
  19. using of INotifyPropertyChanged
  20. Close Window from ViewModel [duplicate]
  21. How to write a ViewModelBase in MVVM
  22. Use StringFormat to add a string to a WPF XAML binding
  23. WPF Error 40 BindingExpression path error: property not found on ‘object’
  24. Use “real” CultureInfo.CurrentCulture in WPF Binding, not CultureInfo from IetfLanguageTag
  25. How to display items in Canvas through Binding
  26. Binding properties in code behind
  27. The component does not have a resource identified by the uri
  28. How to have multiple pairs “View-ViewModel”?
  29. Accessing a property in one ViewModel from another
  30. Is it wrong to use the Dispatcher within my ViewModel?

Leave a Comment