C# Random Numbers aren’t being “random”

by

My guess is that randomNumber creates a new instance of Random each time… which in turn creates a new pseudo-random number generator based on the current time… which doesn’t change as often as you might think.

Don’t do that. Use the same instance of Random repeatedly… but don’t “fix” it by creating a static Random variable. That won’t work well either in the long term, as Random isn’t thread-safe. It will all look fine in testing, then you’ll mysteriously get all zeroes back after you happen to get unlucky with concurrency 🙁

Fortunately it’s not too hard to get something working using thread-locals, particularly if you’re on .NET 4. You end up with a new instance of Random per thread.

I’ve written an article on this very topic which you may find useful, including this code:

using System;
using System.Threading;

public static class RandomProvider
{    
    private static int seed = Environment.TickCount;

    private static ThreadLocal<Random> randomWrapper = new ThreadLocal<Random>
        (() => new Random(Interlocked.Increment(ref seed)));

    public static Random GetThreadRandom()
    {
        return randomWrapper.Value;
    }
}

If you change your new Random() call to RandomProvider.GetThreadRandom() that will probably do everything you need (again, assuming .NET 4). That doesn’t address testability, but one step at a time…

More Related Contents:

  1. Is C# Random Number Generator thread safe?
  2. Generate random string from list of string in C#? [closed]
  3. How to generate random binary numbers 0 or 1 with length of N and with option to control the probability of having 0 or 1?
  4. C# Switch Randomized [closed]
  5. How can I get more than one random numbers in a specific range using C#?
  6. How can I generate random alphanumeric strings?
  7. Random.Next returns always the same values [duplicate]
  8. Most efficient way to randomly “sort” (Shuffle) a list of integers in C#
  9. Select N random elements from a List in C#
  10. Generating Random Passwords
  11. Random weighted choice
  12. Why does it appear that my random number generator isn’t random in C#?
  13. How to elegantly check if a number is within a range?
  14. Generics – where T is a number? [duplicate]
  15. Why use the C# class System.Random at all instead of System.Security.Cryptography.RandomNumberGenerator?
  16. How to get the closest number from a List with LINQ?
  17. Generating a Random Decimal in C#
  18. Standalone numbers Regex?
  19. Random date in C#
  20. How to generate random color names in C#
  21. What is the best way to generate random numbers in C++?
  22. Random encounter not so random
  23. How to get a random number from a range, excluding some values
  24. Octal equivalent in C#
  25. Generate random values in C#
  26. How to get random values from array in C# [duplicate]
  27. C# Select random element from List
  28. Formatting Numbers as Strings with Commas in place of Decimals
  29. How is a random number generated at runtime?
  30. How to save the state of a Random generator in C#? [duplicate]

Leave a Comment