CA2202, how to solve this case

by

You should suppress the warnings in this case. Code that deals with disposables should be consistent, and you shouldn’t have to care that other classes take ownership of the disposables you created and also call Dispose on them.

[SuppressMessage("Microsoft.Usage", "CA2202:Do not dispose objects multiple times")]
public static byte[] Encrypt(string data, byte[] key, byte[] iv) {
  using (var memoryStream = new MemoryStream()) {
    using (var cryptograph = new DESCryptoServiceProvider())
    using (var cryptoStream = new CryptoStream(memoryStream, cryptograph.CreateEncryptor(key, iv), CryptoStreamMode.Write))
    using (var streamWriter = new StreamWriter(cryptoStream)) {
      streamWriter.Write(data);
    }
    return memoryStream.ToArray();
  }
}

UPDATE: In the IDisposable.Dispose documentation you can read this:

If an object’s Dispose method is called more than once, the object must ignore all calls after the first one. The object must not throw an exception if its Dispose method is called multiple times.

It can be argued that this rule exists so that developers can employ the using statement sanely in a cascade of disposables, like I’ve shown above (or maybe this is just a nice side-effect). By the same token, then, CA2202 serves no useful purpose, and it should be suppressed project-wise. The real culprit would be a faulty implementation of Dispose, and CA1065 should take care of that (if it’s under your responsibility).

More Related Contents:

  1. Collection versus List what should you use on your interfaces?
  2. Is there a tool for finding unreferenced functions (dead, obsolete code) in a C# app? [closed]
  3. Could not establish trust relationship for SSL/TLS secure channel — SOAP
  4. How to detect the currently pressed key?
  5. How to embed a text file in a .NET assembly?
  6. Merging two images in C#/.NET
  7. View/edit ID3 data for MP3 files
  8. Is a memory leak created if a MemoryStream in .NET is not closed?
  9. process.WaitForExit() asynchronously
  10. How to generate .NET 4.0 classes from xsd?
  11. Disposing WPF User Controls
  12. JToken: Get raw/original JSON value
  13. GUI and windows service communication
  14. Creating Directories in a ZipArchive C# .Net 4.5
  15. working with incredibly large numbers in .NET
  16. GC.Collect()
  17. How to remove a single Attribute (e.g. ReadOnly) from a File?
  18. Is the Linq Count() faster or slower than List.Count or Array.Length?
  19. Is this a bad practice to catch a non-specific exception such as System.Exception? Why?
  20. Ghost-borders (‘ringing’) when resizing in GDI+
  21. C# Windows Form .Net and DOS Console
  22. .NET Core and System.Drawing
  23. .Net regex: what is the word character \w?
  24. How to List Directory Contents with FTP in C#?
  25. How to create a Button that can send keys to a conrol without losing focus – Virtual Keyboard
  26. Why doesn’t C# support implied generic types on class constructors?
  27. Explanation of Func
  28. .net connection pooling
  29. Repository Pattern, POCO, and Business Entities
  30. Two Types not equal that should be

Leave a Comment