Caching a promise object in AngularJS service

by

Is this the right approach?

Yes. The use of memoisation on functions that return promises a common technique to avoid the repeated execution of asynchronous (and usually expensive) tasks. The promise makes the caching easy because one does not need to distinguish between ongoing and finished operations, they’re both represented as (the same) promise for the result value.

Is this the right solution?

No. That global data variable and the resolution with undefined is not how promises are intended to work. Instead, fulfill the promise with the result data! It also makes coding a lot easier:

var dataPromise = null;

function getData() {
    if (dataPromise == null)
        dataPromise = $http.get("data.json").then(function (res) {
           return res.data;
        });
    return dataPromise;
}

Then, instead of loadDataPromise().then(function() { /* use global */ data }) it is simply getData().then(function(data) { … }).

To further improve the pattern, you might want to hide dataPromise in a closure scope, and notice that you will need a lookup for different promises when getData takes a parameter (like the url).

More Related Contents:

  1. How to access the value of a promise?
  2. Does never resolved promise cause memory leak?
  3. How do I use Bluebird with Angular?
  4. How can I access the value of a promise?
  5. Make angular.forEach wait for promise after going to next object
  6. AngularJS : Initialize service with asynchronous data
  7. Why are Callbacks from Promise `.then` Methods an Anti-Pattern
  8. What’s the difference between returning value or Promise.resolve from then()
  9. Break promise chain and call a function based on the step in the chain where it is broken (rejected)
  10. multiple, sequential fetch() Promise
  11. Unit-test promise-based code in Angularjs
  12. TypeError: Cannot read property ‘then’ of undefined
  13. Angular 1.6.0: “Possibly unhandled rejection” error [duplicate]
  14. How can I access a variable outside a promise `.then` method?
  15. ES6 Promise not Updating AngularJS DOM [duplicate]
  16. What happens with $q.all() when some calls work and others fail?
  17. Produce a promise which depends on recursive promises
  18. AngularJS Promises, $q, defer
  19. WebSocket connection failed: Error during WebSocket handshake: Unexpected response code: 400
  20. Two way binding not working in directive with transcluded scope
  21. angularjs form reset error
  22. Angular – extending $resource subobject with custom methods
  23. Angular JS – Make service globally accessible from controllers and view
  24. Is there a more effective way to serialize a form with angularjs?
  25. FormData how to get or set boundary in multipart/form-data – Angular
  26. How to usemultiple Angular UI Bootstrap Datepicker in single form?
  27. How to return a promise when writestream finishes?
  28. Why does JavaScript Promise then handler run after other code?
  29. Promise.all is returning an array of undefined and resolves before being done
  30. I don’t understand the use of $inject in controllers

Leave a Comment