Why are Callbacks from Promise `.then` Methods an Anti-Pattern

by

You should change it to 

var getTokens = function() {
      return $http.get('/api/tokens');
    };

And, then in other module use

yourModule.getTokens()
  .then(function(response) {
    // handle it
  });

As to why it’s an anti-pattern, I’d say that, first, it doesn’t allow you to further chain your success/fail handler methods. Second, it handles the control of processing the response from caller-module to called module (which might not be super-important here, but it still imposes same inversion of control). And finally, you add the concept of promises to your codebase, which might not be so easy to understand for some of the teammates, but then use promises as callbacks, so this really makes no sense.

More Related Contents:

  1. How to access the value of a promise?
  2. AngularJS : Initialize service with asynchronous data
  3. Caching a promise object in AngularJS service
  4. Does never resolved promise cause memory leak?
  5. How do I use Bluebird with Angular?
  6. Angular 1.6.0: “Possibly unhandled rejection” error [duplicate]
  7. How can I access a variable outside a promise `.then` method?
  8. ES6 Promise not Updating AngularJS DOM [duplicate]
  9. What happens with $q.all() when some calls work and others fail?
  10. How can I access the value of a promise?
  11. Make angular.forEach wait for promise after going to next object
  12. How to define two angular apps / modules in one page?
  13. How to set bootstrap navbar active class with Angular JS?
  14. AngularJS does not send hidden field value
  15. Problems with circular dependency and OOP in AngularJS
  16. Adding a custom header to HTTP request using angular.js
  17. Angular.module minification bug
  18. Angular ui-router – how to access parameters in nested, named view, passed from the parent template?
  19. Angular.JS: views sharing same controller, model data resets when changing view
  20. How to pass parameters to a modal?
  21. key-value pairs in ng-options
  22. deep merge objects with AngularJS
  23. Angular UI Router: decide child state template on the basis of parent resolved object
  24. AngularJS : Asynchronously initialize filter
  25. VueJs templating. How to load external templates
  26. Format Date time in AngularJS
  27. How to create a custom input type?
  28. Using page’s angular JS in chrome extension
  29. Angular controller scope not updating after jQuery ajax call
  30. Blob download is not working in IE

Leave a Comment