Calling async method on button click

by

You’re the victim of the classic deadlock. task.Wait() or task.Result is a blocking call in UI thread which causes the deadlock.

Don’t block in the UI thread. Never do it. Just await it.

private async void Button_Click(object sender, RoutedEventArgs 
{
      var task = GetResponseAsync<MyObject>("my url");
      var items = await task;
}

Btw, why are you catching the WebException and throwing it back? It would be better if you simply don’t catch it. Both are same.

Also I can see you’re mixing the asynchronous code with synchronous code inside the GetResponse method. StreamReader.ReadToEnd is a blocking call –you should be using StreamReader.ReadToEndAsync.

Also use “Async” suffix to methods which returns a Task or asynchronous to follow the TAP(“Task based Asynchronous Pattern”) convention as Jon says.

Your method should look something like the following when you’ve addressed all the above concerns.

public static async Task<List<T>> GetResponseAsync<T>(string url)
{
    HttpWebRequest request = (HttpWebRequest)HttpWebRequest.Create(url);
    var response = (HttpWebResponse)await Task.Factory.FromAsync<WebResponse>(request.BeginGetResponse, request.EndGetResponse, null);

    Stream stream = response.GetResponseStream();
    StreamReader strReader = new StreamReader(stream);
    string text = await strReader.ReadToEndAsync();

    return JsonConvert.DeserializeObject<List<T>>(text);
}

More Related Contents:

  1. C# Threading/Async: Running a task in the background while UI is interactable
  2. The calling thread cannot access this object because a different thread owns it
  3. How to use WPF Background Worker
  4. If async-await doesn’t create any additional threads, then how does it make applications responsive?
  5. How do I update an ObservableCollection via a worker thread?
  6. Implement C# Generic Timeout
  7. How to update GUI with backgroundworker?
  8. How to update UI from another thread running in another class
  9. When to use BlockingCollection and when ConcurrentBag instead of List?
  10. How to correctly implement a BackgroundWorker with ProgressBar updates?
  11. Accessing UI (Main) Thread safely in WPF
  12. Task continuation on UI thread
  13. Async process start and wait for it to finish
  14. The calling thread cannot access this object because a different thread owns it.WPF [duplicate]
  15. “async Task then await Task” vs “Task then return task” [duplicate]
  16. Named Mutex with await
  17. Using BindingOperations.EnableCollectionSynchronization
  18. Calling async methods from non-async code
  19. Is .GetAwaiter().GetResult(); safe for general use?
  20. Error: Must create DependencySource on same Thread as the DependencyObject even by using Dispatcher
  21. Async thread body loop, It just works, but how?
  22. WPF loading animation on a separate UI thread? (C#)
  23. Async WebApi Thread.CurrentCulture
  24. How do you pass a BitmapImage from a background thread to the UI thread in WPF?
  25. Synchronous implementation of interface that returns Task
  26. What is the difference between .Wait() vs .GetAwaiter().GetResult()?
  27. Async and Await with For Loop [duplicate]
  28. Calling an async method from a synchronous method
  29. How to execute a method periodically from WPF client application using threading or timer [closed]
  30. Calling TaskCompletionSource.SetResult in a non blocking manner

Leave a Comment