Calling virtual function from destructor

by

I am going to go against the flow here… but first, I must assume that your PublicBase destructor is virtual, as otherwise the Derived destructor will never be called.

It is usually not a good idea to call a virtual function from a constructor/destructor

The reason for this is that dynamic dispatch is strange during these two operations. The actual type of the object changes during construction and it changes again during destruction. When a destructor is being executed, the object is of exactly that type, and never a type derived from it. Dynamic dispatch is in effect at all time, but the final overrider of the virtual function will change depending where in the hierarchy you are.

That is, you should never expect a call to a virtual function in a constructor/destructor to be executed in any type that derived from the type of the constructor/destructor being executed.

But

In your particular case, the final overrider (at least for this part of the hierarchy) is above your level. Moreover, you are not using dynamic dispatch at all. The call PrivateBase::FunctionCall(); is statically resolved, and effectively equivalent to a call to any non-virtual function. The fact that the function is virtual or not does not affect this call.

So yes it is fine doing as you are doing, although you will be forced to explain this in code reviews as most people learn the mantra of the rule rather than the reason for it.

More Related Contents:

  1. Why doesn’t polymorphism work without pointers/references?
  2. Virtual/pure virtual explained
  3. c++ virtual inheritance
  4. Accessing class members on a NULL pointer
  5. C++ virtual function from constructor [duplicate]
  6. virtual assignment operator C++
  7. C++ static virtual members?
  8. CRTP to avoid dynamic polymorphism
  9. C++ Virtual template method
  10. Making operator
  11. How to achieve “virtual template function” in C++
  12. C++ What is the purpose of casting to void? [duplicate]
  13. How does virtual method invocation work in C++?
  14. C++ inherit from multiple base classes with the same virtual function name
  15. virtual inheritance [duplicate]
  16. sizeof class with int , function, virtual function in C++?
  17. Print address of virtual member function
  18. Size of the classes in case of virtual inheritance
  19. Pointers to virtual member functions. How does it work?
  20. C++ virtual override functions with same name
  21. Understanding virtual base classes and constructor calls
  22. Calling derived class function from base class
  23. C++ Virtual function being hidden
  24. Template definitions outside class body
  25. C++ virtual function table memory cost
  26. Can I get polymorphic behavior without using virtual functions?
  27. C++ covariance in parameters
  28. Why does a virtual function get hidden?
  29. Object layout in case of virtual functions and multiple inheritance
  30. Does C++ support named parameters?

Leave a Comment