Confused by squaring macro SQR in c [duplicate]

by

SQR(1+1) expands to 1+1*1+1 which is 3, not 4, correct?

A correct definition of the macro would be

#define SQR(x) ((x)*(x))

which expands to (1+1)*(1+1) and, more important, shows you one of the reasons you shouldn’t use macros where they aren’t needed. The following is better:

inline int SQR(int x)
{
    return x*x;
}

Furthermore: SQR(i++) would be undefined behavior if SQR is a macro, and completely correct if SQR is a function.

More Related Contents:

  1. Comma in C/C++ macro
  2. Can we have recursive macros?
  3. How to identify platform/compiler from preprocessor macros?
  4. Escaping a # symbol in a #define macro?
  5. macro definition containing #include directive
  6. Can I redefine a C++ macro then define it back?
  7. How to tame the Windows headers (useful defines)?
  8. Expand macro inside string literal
  9. What is the difference between #include and #include “filename”?
  10. Overloading Macro on Number of Arguments
  11. C macros and use of arguments in parentheses
  12. C++ preprocessor __VA_ARGS__ number of arguments
  13. Inline functions vs Preprocessor macros
  14. What exactly do C include guards do?
  15. Array-size macro that rejects pointers
  16. C/C++, can you #include a file into a string literal? [duplicate]
  17. Portability of #warning preprocessor directive
  18. What are C macros useful for?
  19. Opposite of C preprocessor “stringification”
  20. C/C++ macro/template blackmagic to generate unique name
  21. Difference between Enum and Define Statements
  22. What is the difference between a macro and a const in C++?
  23. What does “#define STR(a) #a” do?
  24. Is the backslash acceptable in C and C++ #include directives?
  25. How to test if preprocessor symbol is #define’d but has no value?
  26. C++ #include semantics
  27. Generate include file name in a macro
  28. How do I temporarily disable a macro expansion in C/C++?
  29. Macros to create strings in C
  30. How can I define a string literal on the GCC command line?

Leave a Comment