Creating a factory method in Java that doesn’t rely on if-else

by

What you’ve done is probably the best way to go about it, until a switch on string is available. (Edit 2019: A switch on string is available – use that.)

You could create factory objects and a map from strings to these. But this does get a tad verbose in current Java.

private interface AnimalFactory {
    Animal create();
}
private static final Map<String,AnimalFactory> factoryMap =
    Collections.unmodifiableMap(new HashMap<String,AnimalFactory>() {{
        put("Meow", new AnimalFactory() { public Animal create() { return new Cat(); }});
        put("Woof", new AnimalFactory() { public Animal create() { return new Dog(); }});
    }});

public Animal createAnimal(String action) {
    AnimalFactory factory = factoryMap.get(action);
    if (factory == null) {
        throw new EhException();
    }
    return factory.create();
}

At the time this answer was originally written, the features intended for JDK7 could make the code look as below. As it turned out, lambdas appeared in Java SE 8 and, as far as I am aware, there are no plans for map literals. (Edited 2016)

private interface AnimalFactory {
    Animal create();
}
private static final Map<String,AnimalFactory> factoryMap = {
    "Meow" : { -> new Cat() },
    "Woof" : { -> new Dog() },
};

public Animal createAnimal(String action) {
    AnimalFactory factory = factoryMap.get(action);
    if (factory == null) {
        throw EhException();
    }
    return factory.create();
}

Edit 2019: Currently this would look something like this.

import java.util.function.*;
import static java.util.Map.entry;

private static final Map<String,Supplier<Animal>> factoryMap = Map.of(
    "Meow", Cat::new, // Alternatively: () -> new Cat()
    "Woof", Dog::new // Note: No extra comma like arrays.
);

// For more than 10, use Map.ofEntries and Map.entry.
private static final Map<String,Supplier<Animal>> factoryMap2 = Map.ofEntries(
    entry("Meow", Cat::new),
    ...
    entry("Woof", Dog::new) // Note: No extra comma.
);

public Animal createAnimal(String action) {
    Supplier<Animal> factory = factoryMap.get(action);
    if (factory == null) {
        throw EhException();
    }
    return factory.get();
}

If you want to add a parameter, you’ll need to switch Supplier to Factory (and get becomes apply which also makes no sense in the context). For two parameters BiFunction. More than two parameters, and you’re back to trying to make it readable again.

More Related Contents:

  1. foo(int) is not applicable for the arguments (String)
  2. Replace a character specific number of times in String Java
  3. Java; Initializing A Count of Input, After Period Is Entered
  4. Difference between String replace() and replaceAll()
  5. Splitting a string at every n-th character
  6. Design Patterns: Factory vs Factory method vs Abstract Factory
  7. Convert float to String and String to float in Java
  8. How can I check if a single character appears in a string?
  9. Why is the String class declared final in Java?
  10. In Java, how do I check if a string contains a substring (ignoring case)? [duplicate]
  11. Fast algorithm for searching for substrings in a string
  12. Java change áéőűú to aeouu [duplicate]
  13. Extracting pairs of words using String.split()
  14. Extract Integer Part in String
  15. String replace a Backslash
  16. Why does this code using random strings print “hello world”?
  17. Remove all empty lines
  18. Does concatenating strings in Java always lead to new strings being created in memory?
  19. Can a valid Unicode string contain FFFF? Is Java/CharacterIterator broken?
  20. When to use intern() on String literals
  21. How do I convert a String to a BigInteger?
  22. How to properly trim whitespaces from a string in Java?
  23. Garbage collection on intern’d strings, String Pool, and perm-space
  24. How Java do the string concatenation using “+”?
  25. “==” in case of String concatenation in Java
  26. Java String ReplaceAll method giving illegal repetition error?
  27. Unable to print russian characters
  28. Using DocumentFilter.FilterBypass
  29. Compare two hex strings in Java?
  30. Behavior of String literals is confusing

Leave a Comment