Disallowing creation of the temporary objects

by

Edit: As j_random_hacker notes, it is possible to force the user to declare a named object in order to take out a lock.

However, even if creation of temporaries was somehow banned for your class, then the user could make a similar mistake:

// take out a lock:
if (m_multiThreaded)
{
    CSingleLock c(&m_criticalSection, TRUE);
}

// do other stuff, assuming lock is held

Ultimately, the user has to understand the impact of a line of code that they write. In this case, they have to know that they’re creating an object and they have to know how long it lasts.

Another likely mistake:

 CSingleLock *c = new CSingleLock(&m_criticalSection, TRUE);

 // do other stuff, don't call delete on c...

Which would lead you to ask “Is there any way I can stop the user of my class from allocating it on the heap”? To which the answer would be the same.

In C++0x there will be another way to do all this, by using lambdas. Define a function:

template <class TLock, class TLockedOperation>
void WithLock(TLock *lock, const TLockedOperation &op)
{
    CSingleLock c(lock, TRUE);
    op();
}

That function captures the correct usage of CSingleLock. Now let users do this:

WithLock(&m_criticalSection, 
[&] {
        // do stuff, lock is held in this context.
    });

This is much harder for the user to screw up. The syntax looks weird at first, but [&] followed by a code block means “Define a function that takes no args, and if I refer to anything by name and it is the name of something outside (e.g. a local variable in the containing function) let me access it by non-const reference, so I can modify it.)

More Related Contents:

  1. how to convert wchar_t* type variable to wchar_t[ ] type array? [closed]
  2. How come a non-const reference cannot bind to a temporary object?
  3. Does a const reference class member prolong the life of a temporary?
  4. Lifetime of temporaries
  5. Convert CString to const char*
  6. LPCSTR, LPCTSTR and LPTSTR
  7. StdAfx + Header file – Order of inclusion in MFC application
  8. constant references with typedef and templates in c++
  9. WaitForInputIdle doesn’t work for starting mspaint programmatically
  10. How do you convert CString and std::string std::wstring to each other?
  11. Why lifetime of temporary doesn’t extend till lifetime of enclosing object?
  12. App does not run with VS 2008 SP1 DLLs, previous version works with RTM versions
  13. Why does calling std::string.c_str() on a function that returns a string not work?
  14. Why stdfax.h should be the first include on MFC applications? [duplicate]
  15. Creating HBITMAP from memory buffer
  16. Why is taking the address of a temporary illegal?
  17. Difference between a C++ exception and Structured Exception
  18. prolonging the lifetime of temporaries
  19. Dynamic menu using mfc
  20. How to Run Only One Instance of Application
  21. Is it safe to make a const reference member to a temporary variable?
  22. How can we vertically align text in edit box?
  23. Windows Media Foundation recording audio
  24. Questions regarding constructors
  25. What does “dereferencing” a pointer mean?
  26. Displaying the #include hierarchy for a C++ file in Visual Studio
  27. How to get screenshot of a window as bitmap object in C++?
  28. For nested templates, when did `>>` become standard C++ (instead of `> >`)?
  29. For loop prints an extra comma
  30. How is floating point conversion actually done in C++?(double to float or float to double)

Leave a Comment