Do capture lists of inner closures need to redeclare `self` as `weak` or `unowned`?

by

The [weak self] in anotherFunctionWithTrailingClosure is not needed.

You can empirically test this:

class Experiment {
    func someFunctionWithTrailingClosure(closure: @escaping () -> Void) {
        print("starting", #function)
        DispatchQueue.main.asyncAfter(deadline: .now() + 1) {
            closure()
            print("finishing", #function)
        }
    }

    func anotherFunctionWithTrailingClosure(closure: @escaping () -> Void) {
        print("starting", #function)
        DispatchQueue.main.asyncAfter(deadline: .now() + 1) {
            closure()
            print("finishing", #function)
        }
    }

    func doSomething() {
        print(#function)
    }

    func testCompletionHandlers() {
        someFunctionWithTrailingClosure { [weak self] in
            self?.anotherFunctionWithTrailingClosure { // [weak self] in
                self?.doSomething()
            }
        }
    }

    // go ahead and add `deinit`, so I can see when this is deallocated

    deinit {
        print("deinit")
    }
}

And then:

func performExperiment() {
    DispatchQueue.global().async {
        let obj = Experiment()

        obj.testCompletionHandlers()

        // sleep long enough for `anotherFunctionWithTrailingClosure` to start, but not yet call its completion handler

        Thread.sleep(forTimeInterval: 1.5)
    }
}

If you do this, you will see that doSomething is never called and that deinit is called before anotherFunctionWithTrailingClosure calls its closure.

That having been said, I might still be inclined to use the [weak self] syntax on anotherFunctionWithTrailingClosure to make my intent explicit.

More Related Contents:

  1. What is the difference between a weak reference and an unowned reference?
  2. How do I declare an array of weak references in Swift?
  3. Shall we always use [unowned self] inside closure in Swift
  4. Escaping Closures in Swift
  5. Unexpected Non-Void Return Value In Void Function (Swift 2.0)
  6. Swift optional escaping closure parameter
  7. Where does the weak self go?
  8. Can Swift return value from an async Void-returning block?
  9. Swift @escaping and Completion Handler
  10. Knowing where retain cycles are and removing them
  11. Swift closure async order of execution
  12. How can I create a reference cycle using dispatchQueues?
  13. Swift 5 : What’s ‘Escaping closure captures mutating ‘self’ parameter’ and how to fix it
  14. @noescape attribute in Swift 1.2
  15. How To make Label like below image in swift
  16. Swift generic coercion misunderstanding
  17. Sort Dictionary by keys
  18. How can I use Swift’s Codable to encode into a dictionary?
  19. How to disable pasting in a TextField in Swift?
  20. Swift – SpriteKit CGPoint Alignment
  21. Swift generics not preserving type
  22. Using NavigationLink in Menu (SwiftUI)
  23. Swift: setting an optional property of a protocol
  24. Swift: failing to copy files to a newly created folder
  25. Convert Character to Int in Swift 2.0
  26. Getting the coordinates from the location I touch the touchscreen
  27. How does Apple’s new programming language Swift handle blocks and asynchronous requests?
  28. UIBezierPath doesn’t work in TopRight corner and BottomRight corner
  29. How we can get and read size of a Text with GeometryReader in SwiftUI?
  30. Firebase getting data in order

Leave a Comment