Unexpected Non-Void Return Value In Void Function (Swift 2.0)

by

You have a problem because your line:

return minions

does not return from your function. Instead, it returns from the completion handler in dataTaskWithRequest. And it shouldn’t be doing so because that closure is a void function.

The problem which you have results from the fact that dataTaskWithRequest is an asynchronous operation. Which means that it can return later after executing your function.

So, you need to change your design pattern.

One way of doing that would be the following:

static var minions:[Minion] = [] {
    didSet {
        NSNotificationCenter.defaultCenter().postNotificationName("minionsFetched", object: nil)
   }
}



class func fetchMinionData() {

    var myURL = "http://myurl/test.json"
    let dataURL = NSURL(string: myURL)
    let request = NSURLRequest(URL: dataURL!, cachePolicy: .ReloadIgnoringLocalAndRemoteCacheData, timeoutInterval: 5.0)

    let session = NSURLSession.sharedSession()

    session.dataTaskWithRequest(request, completionHandler: {(data, response, error) in
        let minionJSON = JSON(data!)

        var minions = [Minion]()

        for (_, minionDictionary) in minionJSON {
            minions.append(Minion(minionDetails: minionDictionary))
        }

        self.minions = minions
        //THIS IS WHERE THE ERROR OCCURS

    }).resume()
}

Then before calling your function you should register to listen for NSNotification with name “minionsFetched”. And only after you get that notification you should process the minions as if they were fetched.

More Related Contents:

  1. How can I get the Data from NSURLSession.sharedSession().dataTaskWithRequest
  2. Escaping Closures in Swift
  3. How to use special character in NSURL?
  4. NSURLSession concurrent requests with Alamofire
  5. Swift optional escaping closure parameter
  6. Can Swift return value from an async Void-returning block?
  7. Swift @escaping and Completion Handler
  8. Swift closure async order of execution
  9. How can I create a reference cycle using dispatchQueues?
  10. Swift 5 : What’s ‘Escaping closure captures mutating ‘self’ parameter’ and how to fix it
  11. @noescape attribute in Swift 1.2
  12. Do capture lists of inner closures need to redeclare `self` as `weak` or `unowned`?
  13. Precision String Format Specifier In Swift
  14. Swift generic coercion misunderstanding
  15. Sort Dictionary by keys
  16. Swift 2 – UnsafeMutablePointer to object
  17. How to generate a random number in Swift without repeating the previous random number?
  18. How to set cell spacing and UICollectionView – UICollectionViewFlowLayout size ratio?
  19. Difference between computed property and property set with closure
  20. Unable to run app in Simulator : An error was encountered while running (Domain = LaunchServicesError, Code = 0)
  21. SwiftUI picker separate texts for selected item and selection view
  22. Multiple functions with the same name
  23. SwiftUI Drag and Drop files
  24. Using “if let…” with many expressions
  25. Swift – Custom setter on property
  26. SpriteKit physics in Swift – Ball slides against wall instead of reflecting
  27. What is the real benefit of using Raycast in ARKit and RealityKit?
  28. Swift: shortcut unwrapping of array of optionals
  29. How do I perform an auto-segue in Xcode 6 using Swift?
  30. Can Swift convert a class / struct data into dictionary?

Leave a Comment