Eager load polymorphic

by

My guess is that your models look like this:

class User < ActiveRecord::Base
  has_many :reviews
end

class Review < ActiveRecord::Base
  belongs_to :user
  belongs_to :reviewable, polymorphic: true
end

class Shop < ActiveRecord::Base
  has_many :reviews, as: :reviewable
end

You are unable to do that query for several reasons.

  1. ActiveRecord is unable to build the join without additional information.
  2. There is no table called reviewable

To solve this issue, you need to explicitly define the relationship between Review and Shop.

class Review < ActiveRecord::Base
   belongs_to :user
   belongs_to :reviewable, polymorphic: true
   # For Rails < 4
   belongs_to :shop, foreign_key: 'reviewable_id', conditions: "reviews.reviewable_type="Shop""
   # For Rails >= 4
   belongs_to :shop, -> { where(reviews: {reviewable_type: 'Shop'}) }, foreign_key: 'reviewable_id'
   # Ensure review.shop returns nil unless review.reviewable_type == "Shop"
   def shop
     return unless reviewable_type == "Shop"
     super
   end
end

Then you can query like this:

Review.includes(:shop).where(shops: {shop_type: 'cafe'})

Notice that the table name is shops and not reviewable. There should not be a table called reviewable in the database.

I believe this to be easier and more flexible than explicitly defining the join between Review and Shop since it allows you to eager load in addition to querying by related fields.

The reason that this is necessary is that ActiveRecord cannot build a join based on reviewable alone, since multiple tables represent the other end of the join, and SQL, as far as I know, does not allow you join a table named by the value stored in a column. By defining the extra relationship belongs_to :shop, you are giving ActiveRecord the information it needs to complete the join.

More Related Contents:

  1. Rails order by results count of has_many association
  2. How to chain scope queries with OR instead of AND?
  3. When to use a “has_many :through” relation in Rails?
  4. Rails 3: Get Random Record
  5. Setting session timeout in Rails 3
  6. Alias for column names in Rails
  7. ActiveRecord Find By Year, Day or Month on a Date field
  8. Rails 3 devise, current_user is not accessible in a Model ?
  9. Rails 3, has_one / has_many with lambda condition
  10. Rails 3 – select with Include?
  11. belongs_to through associations
  12. Check if record exists from controller in Rails
  13. Validate uniqueness of multiple columns
  14. Rails – Validate Presence Of Association?
  15. How to implement bulk insert in Rails 3
  16. PGError: ERROR: aggregates not allowed in WHERE clause on a AR query of an object and its has_many objects
  17. Specifying column name in a “references” migration
  18. Rails: Order with nulls last
  19. Best way to load module/class from lib folder in Rails 3?
  20. Why doesn’t `config.time_zone` seem to do anything?
  21. query , can not select column count
  22. Can we call a Controller’s method from a view (as we call from helper ideally)?
  23. Using helpers in model: how do I include helper dependencies?
  24. Use rvmrc or ruby-version file to set a project gemset with RVM?
  25. How to change the default path of view files in a Rails 3 controller?
  26. Rails has_many through form with checkboxes and extra field in the join model
  27. Changing the base URL for Rails 3 development
  28. Ruby on Rails 3 howto make ‘OR’ condition
  29. Adding foreign key to a rails model
  30. How can I use ActiveRecord on a database that has a column named ‘valid’? (DangerousAttributeError)

Leave a Comment