ExecutorService, how to wait for all tasks to finish

by

The simplest approach is to use ExecutorService.invokeAll() which does what you want in a one-liner. In your parlance, you’ll need to modify or wrap ComputeDTask to implement Callable<>, which can give you quite a bit more flexibility. Probably in your app there is a meaningful implementation of Callable.call(), but here’s a way to wrap it if not using Executors.callable().

ExecutorService es = Executors.newFixedThreadPool(2);
List<Callable<Object>> todo = new ArrayList<Callable<Object>>(singleTable.size());

for (DataTable singleTable: uniquePhrases) { 
    todo.add(Executors.callable(new ComputeDTask(singleTable))); 
}

List<Future<Object>> answers = es.invokeAll(todo);

As others have pointed out, you could use the timeout version of invokeAll() if appropriate. In this example, answers is going to contain a bunch of Futures which will return nulls (see definition of Executors.callable(). Probably what you want to do is a slight refactoring so you can get a useful answer back, or a reference to the underlying ComputeDTask, but I can’t tell from your example.

If it isn’t clear, note that invokeAll() will not return until all the tasks are completed. (i.e., all the Futures in your answers collection will report .isDone() if asked.) This avoids all the manual shutdown, awaitTermination, etc… and allows you to reuse this ExecutorService neatly for multiple cycles, if desired.

There are a few related questions on SO:

None of these are strictly on-point for your question, but they do provide a bit of color about how folks think Executor/ExecutorService ought to be used.

More Related Contents:

  1. Turning an ExecutorService to daemon in Java
  2. FixedThreadPool vs CachedThreadPool: the lesser of two evils
  3. Removing all queued tasks of an ThreadPoolExecutor
  4. Dynamic Thread Pool
  5. How to wait for all threads to finish, using ExecutorService?
  6. ExecutorService that interrupts tasks after a timeout
  7. Handling exceptions from Java ExecutorService tasks
  8. Executors.newCachedThreadPool() versus Executors.newFixedThreadPool()
  9. Naming threads and thread-pools of ExecutorService
  10. Choose between ExecutorService’s submit and ExecutorService’s execute
  11. What are the advantages of using an ExecutorService?
  12. Is ExecutorService (specifically ThreadPoolExecutor) thread safe?
  13. Threads configuration based on no. of CPU-cores
  14. Impossible to make a cached thread pool with a size limit?
  15. How are Threads allocated to handle Servlet request?
  16. ThreadPoolExecutor Block When Queue Is Full?
  17. Java ExecutorService: awaitTermination of all recursively created tasks
  18. How to use invokeAll() to let all thread pool do their task?
  19. How to shutdown an ExecutorService?
  20. AsyncTask.executeOnExecutor() before API Level 11
  21. ThreadPoolExecutor Block When its Queue Is Full?
  22. Java: ExecutorService that blocks on submission after a certain queue size [duplicate]
  23. How to stop all runnable thread in java executor class?
  24. How Threadpool re-use Threads and how it works
  25. ExecutorService vs Casual Thread Spawner
  26. How to pause/resume all threads in an ExecutorService in Java?
  27. Java Executors: how can I stop submitted tasks?
  28. Shutdown ExecutorService gracefully in webapp?
  29. JAVAFX : why wait cursor needs a new thread?
  30. ExecutorCompletionService? Why do need one if we have invokeAll?

Leave a Comment