Fill Combobox from database

by

You will have to completely re-write your code. DisplayMember and ValueMember point to columnNames! Furthermore you should really use a using block – so the connection gets disposed (and closed) after query execution.

Instead of using a dataReader to access the values I choosed a dataTable and bound it as dataSource onto the comboBox.

using (SqlConnection conn = new SqlConnection(@"Data Source=SHARKAWY;Initial Catalog=Booking;Persist Security Info=True;User ID=sa;Password=123456"))
{
    try
    {
        string query = "select FleetName, FleetID from fleets";
        SqlDataAdapter da = new SqlDataAdapter(query, conn);
        conn.Open();
        DataSet ds = new DataSet();
        da.Fill(ds, "Fleet");
        cmbTripName.DisplayMember =  "FleetName";
        cmbTripName.ValueMember = "FleetID";
        cmbTripName.DataSource = ds.Tables["Fleet"];
    }
    catch (Exception ex)
    {
        // write exception info to log or anything else
        MessageBox.Show("Error occured!");
    }               
}

Using a dataTable may be a little bit slower than a dataReader but I do not have to create my own class. If you really have to/want to make use of a DataReader you may choose @Nattrass approach. In any case you should write a using block!

EDIT

If you want to get the current Value of the combobox try this

private void cmbTripName_SelectedIndexChanged(object sender, EventArgs e)
{
    if (cmbTripName.SelectedItem != null)
    {
        DataRowView drv = cmbTripName.SelectedItem as DataRowView;

        Debug.WriteLine("Item: " + drv.Row["FleetName"].ToString());
        Debug.WriteLine("Value: " + drv.Row["FleetID"].ToString());
        Debug.WriteLine("Value: " + cmbTripName.SelectedValue.ToString());
    }
}

More Related Contents:

  1. Index was outside the bounds of the array how to resolve
  2. Binding a WPF ComboBox to a custom list
  3. How do I bind a WPF DataGrid to a variable number of columns?
  4. How to bind a List to a ComboBox?
  5. Data binding dynamic data
  6. Databinding to List – See changes of data source in ListBox, ComboBox
  7. List vs BindingList Advantages/DisAdvantages
  8. databind the Source property of the WebBrowser in WPF
  9. How to set a binding in Code?
  10. WPF databinding to interface and not actual object – casting possible?
  11. How to force a WPF binding to refresh?
  12. how to bind datatable to datagridview in c#
  13. How to format TimeSpan in XAML
  14. How to hide wpf datagrid columns depending on a property
  15. Binding DataGrid to ObservableCollection
  16. WPF DataBinding not updating?
  17. CompositeCollection + CollectionContainer: Bind CollectionContainer.Collection to property of ViewModel that is used as DataTemplates DataType
  18. How to set selected value from Combobox?
  19. Content of a Button Style appears only in one Button instance
  20. Notify binding for static properties in static classes
  21. Data binding for TextBox
  22. ORA-01008: not all variables bound. They are bound
  23. WPF checkbox binding
  24. Is it possible to bind complex type properties to a datagrid?
  25. Can I somehow temporarily disable WPF data binding changes?
  26. Is it possible to bind a List to a ListView in WinForms?
  27. WPF TwoWay Binding to a static class Property
  28. Best way to databind a group of radiobuttons in WinForms
  29. Winforms : How to bind the Checkbox item of a CheckedListBox with databinding
  30. Binding to custom control inside DataTemplate for ItemsControl

Leave a Comment