getline not asking for input? [duplicate]

by

You have to be careful when mixing operator>> with getline. The problem is, when you use operator>>, the user enters their data, then presses the enter key, which puts a newline character into the input buffer. Since operator>> is whitespace delimited, the newline character is not put into the variable, and it stays in the input buffer. Then, when you call getline, a newline character is the only thing it’s looking for. Since that’s the first thing in the buffer, it finds what it’s looking for right away, and never needs to prompt the user.

Fix:
If you’re going to call getline after you use operator>>, call ignore in between, or do something else to get rid of that newline character, perhaps a dummy call to getline.

Another option, and this is along the lines of what Martin was talking about, is to not use operator>> at all, and only use getline, then convert your strings to whatever datatype you need. This has a side effect of making your code more safe and robust. I would first write a function like this:

int getInt(std::istream & is)
{
    std::string input;
    std::getline(is,input);

    // C++11 version
    return stoi(input); // throws on failure

    // C++98 version
    /*
    std::istringstream iss(input);
    int i;
    if (!(iss >> i)) {
        // handle error somehow
    }
    return i;
    */
}

You can create a similar function for floats, doubles and other things. Then when you need in int, instead of this:

cin >> i;

You do this:

i = getInt(cin);

More Related Contents:

  1. Using getline(cin, s) after cin [duplicate]
  2. cin and getline skipping input [duplicate]
  3. When and why do I need to use cin.ignore() in C++?
  4. std::cin.getline( ) vs. std::cin
  5. std::getline on std::cin
  6. cin.getline() is skipping an input in C++ [duplicate]
  7. C++ Reading an unknown number of integers to cin and outputting the sum
  8. How to accept a string and an int using cin?
  9. c++ if specific words from string
  10. std::cin input with spaces?
  11. How do I flush the cin buffer?
  12. Infinite loop with cin when typing string while a number is expected
  13. Need help with getline() [duplicate]
  14. changing the delimiter for cin (c++)
  15. Checking cin input stream produces an integer
  16. How to cin Space in c++?
  17. c++ getline() isn’t waiting for input from console when called multiple times
  18. Using getline() in C++
  19. Hide user input on password prompt [duplicate]
  20. Correct way to use cin.fail()
  21. c++ Read from .csv file
  22. How to cin values into a vector
  23. How to read cin with whitespace up until a newline character?
  24. cin input (input is an int) when I input a letter, instead of printing back incorrect once, it prints correct once then inc for the rest of the loop
  25. How to signify no more input for string ss in the loop while (cin >> ss)
  26. What am I not understanding about getline+strings?
  27. Press Enter to Continue
  28. How Can I avoid char input for an int variable?
  29. How is “std::cin>>value” evaluated in a while loop?
  30. What’s the difference between getline and std::istream::operator>>()?

Leave a Comment