Infinite loop with cin when typing string while a number is expected

by

Well you always will have an infinite loop, but I know what you really want to know is why cin doesn’t keep prompting for input on each loop iteration causing your infinite loop to freerun.

The reason is because cin fails in the situation you describe and won’t read any more input into those variables. By giving cin bad input, cin gets in the fail state and stops prompting the command line for input causing the loop to free run.

For simple validation, you can try to use cin to validate your inputs by checking whether cin is in the fail state. When fail occurs clear the fail state and force the stream to throw away the bad input. This returns cin to normal operation so you can prompt for more input.

  if (cin.fail())
  {
     cout << "ERROR -- You did not enter an integer";

     // get rid of failure state
     cin.clear(); 

     // From Eric's answer (thanks Eric)
     // discard 'bad' character(s) 
     cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');

  }

For more sophisticated validation, you may wish to read into a string first and do more sophisticated checks on the string to make sure it matches what you expect.

More Related Contents:

  1. how do I validate user input as a double in C++?
  2. C++ Reading an unknown number of integers to cin and outputting the sum
  3. c++ if specific words from string
  4. std::cin input with spaces?
  5. Why would we call cin.clear() and cin.ignore() after reading input?
  6. Using getline(cin, s) after cin [duplicate]
  7. Testing pointers for validity (C/C++)
  8. When and why do I need to use cin.ignore() in C++?
  9. Why do I get an infinite loop if I enter a letter rather than a number? [duplicate]
  10. How to cin Space in c++?
  11. Why does stringstream >> change value of target on failure?
  12. Good input validation loop using cin – C++
  13. How do I deal with the max macro in windows.h colliding with max in std?
  14. Read binary data from std::cin
  15. How to cin values into a vector
  16. How to read cin with whitespace up until a newline character?
  17. How can I validate an integer input [duplicate]
  18. Why is this cin reading jammed?
  19. How to reset std::cin when using it?
  20. cin for an int inputing a char causes Loop that is supposed to check input to go wild
  21. cin.ignore(numeric_limits::max(), ‘\n’)
  22. Multiple inputs on one line
  23. How to signify no more input for string ss in the loop while (cin >> ss)
  24. What is the best way to do input validation in C++ with cin?
  25. Problem of using cin twice
  26. std::getline on std::cin
  27. Press Enter to Continue
  28. cin.getline() is skipping an input in C++ [duplicate]
  29. How Can I avoid char input for an int variable?
  30. What’s the difference between getline and std::istream::operator>>()?

Leave a Comment