Handling errors in Promise.all

by

Promise.all is all or nothing. It resolves once all promises in the array resolve, or reject as soon as one of them rejects. In other words, it either resolves with an array of all resolved values, or rejects with a single error.

Some libraries have something called Promise.when, which I understand would instead wait for all promises in the array to either resolve or reject, but I’m not familiar with it, and it’s not in ES6.

Your code

I agree with others here that your fix should work. It should resolve with an array that may contain a mix of successful values and errors objects. It’s unusual to pass error objects in the success-path but assuming your code is expecting them, I see no problem with it.

The only reason I can think of why it would “not resolve” is that it’s failing in code you’re not showing us and the reason you’re not seeing any error message about this is because this promise chain is not terminated with a final catch (as far as what you’re showing us anyway).

I’ve taken the liberty of factoring out the “existing chain” from your example and terminating the chain with a catch. This may not be right for you, but for people reading this, it’s important to always either return or terminate chains, or potential errors, even coding errors, will get hidden (which is what I suspect happened here):

Promise.all(state.routes.map(function(route) {
  return route.handler.promiseHandler().catch(function(err) {
    return err;
  });
}))
.then(function(arrayOfValuesOrErrors) {
  // handling of my array containing values and/or errors. 
})
.catch(function(err) {
  console.log(err.message); // some coding error in handling happened
});

More Related Contents:

  1. How to return many Promises and wait for them all before doing other stuff
  2. Can I fire and forget a promise in nodejs (ES7)?
  3. What is an unhandled promise rejection?
  4. How to dodge jQuery promises completely when chaining two async jQuery functions?
  5. What is the order of execution in JavaScript promises?
  6. How can I synchronously determine a JavaScript Promise’s state?
  7. ES6 promise settled callback?
  8. When is the body of a Promise executed?
  9. ES6 Promise.all() error handle – Is .settle() needed? [duplicate]
  10. multiple, sequential fetch() Promise
  11. How do I tell if an object is a Promise?
  12. How to use promise in forEach loop of array to populate an object
  13. Should a Promise.reject message be wrapped in Error?
  14. d3.json method doesn’t return my data array
  15. Why can I not throw inside a Promise.catch handler?
  16. ES6 Promises – something like async.each?
  17. Should I refrain from handling Promise rejection asynchronously?
  18. Filtering an array with a function that returns a promise
  19. How to use Typescript with native ES6 Promises
  20. Why are Promises Monads?
  21. Extend Javascript promise and resolve or reject it inside constructor
  22. Promise.all with Firebase DataSnapshot.forEach
  23. ES6 Promise not Updating AngularJS DOM [duplicate]
  24. Why does the Promise constructor require a function that calls ‘resolve’ when complete, but ‘then’ does not – it returns a value instead?
  25. When would someone need to create a deferred?
  26. How to extract data out of a Promise
  27. Why does javascript ES6 Promises continue execution after a resolve?
  28. using await on global scope without async keyword
  29. Why doesn’t the try catch block catch the promise exception?
  30. Promise.resolve().then vs setImmediate vs nextTick

Leave a Comment