Should a Promise.reject message be wrapped in Error?

by

Yes, it most definitely should. A string is not an error, when you have errors usually it means something went wrong which means you’d really enjoy a good stack trace. No error – no stack trace.

Just like with try/catch, if you add .catch to a thrown rejection, you want to be able to log the stack trace, throwing strings ruins that for you.

I’m on mobile so this answer is rather short but I really can’t emphasize enough how important this is. In large (10K+ LoC) apps stack traces in rejections really made the difference between easy remote bug hunting and a long night in the office.

More Related Contents:

  1. What is the explicit promise construction antipattern and how do I avoid it?
  2. How to return many Promises and wait for them all before doing other stuff
  3. How to dodge jQuery promises completely when chaining two async jQuery functions?
  4. Cancel a vanilla ECMAScript 6 Promise chain
  5. When is the body of a Promise executed?
  6. fetch: Reject promise with JSON error object
  7. ES6 Promise.all() error handle – Is .settle() needed? [duplicate]
  8. multiple, sequential fetch() Promise
  9. How do I tell if an object is a Promise?
  10. How to check if an object is a Promise?
  11. How to use promise in forEach loop of array to populate an object
  12. Why can I not throw inside a Promise.catch handler?
  13. using a fetch inside another fetch in javascript
  14. How do I handle errors with promises?
  15. Why does the Promise constructor require a function that calls ‘resolve’ when complete, but ‘then’ does not – it returns a value instead?
  16. What is the difference between “event loop queue” and “job queue”?
  17. What are asynchronous functions in JavaScript? What is “async” and “await” in JavaScript?
  18. When would someone need to create a deferred?
  19. What is the intention behind clause 2.2.4 of Promise/A+ spec?
  20. Why does the Promise object block rendering?
  21. Promises, pass additional parameters to then chain
  22. How to extract data out of a Promise
  23. Node.js: When to use Promises vs Callbacks
  24. How can I export promise result?
  25. ES6 Promise replacement of async.eachLimit / async.mapLimit
  26. Why does JavaScript Promise then handler run after other code?
  27. What are the implications of the recursive joining of Promises in terms of Monads?
  28. When is the body of a Promise constructor callback executed?
  29. Promise.all is returning an array of undefined and resolves before being done
  30. Weird behavior with Promise throwing “Unhandled promise rejection” error

Leave a Comment