Handling warning for possible multiple enumeration of IEnumerable

by

The problem with taking IEnumerable as a parameter is that it tells callers “I wish to enumerate this”. It doesn’t tell them how many times you wish to enumerate.

I can change the objects parameter to be List and then avoid the possible multiple enumeration but then I don’t get the highest object that I can handle.

The goal of taking the highest object is noble, but it leaves room for too many assumptions. Do you really want someone to pass a LINQ to SQL query to this method, only for you to enumerate it twice (getting potentially different results each time?)

The semantic missing here is that a caller, who perhaps doesn’t take time to read the details of the method, may assume you only iterate once – so they pass you an expensive object. Your method signature doesn’t indicate either way.

By changing the method signature to IList/ICollection, you will at least make it clearer to the caller what your expectations are, and they can avoid costly mistakes.

Otherwise, most developers looking at the method might assume you only iterate once. If taking an IEnumerable is so important, you should consider doing the .ToList() at the start of the method.

It’s a shame .NET doesn’t have an interface that is IEnumerable + Count + Indexer, without Add/Remove etc. methods, which is what I suspect would solve this problem.

More Related Contents:

  1. LINQ: Not Any vs All Don’t
  2. Best way to reverse a string
  3. String vs. StringBuilder
  4. Method can be made static, but should it?
  5. How slow are .NET exceptions?
  6. Benchmarking small code samples in C#, can this implementation be improved?
  7. Is String.Contains() faster than String.IndexOf()?
  8. Performance Tests of Serializations used by WCF Bindings
  9. What is the real overhead of try/catch in C#?
  10. Why does ReSharper want to use ‘var’ for everything? [duplicate]
  11. When is optimization premature? [closed]
  12. Why is LINQ .Where(predicate).First() faster than .First(predicate)?
  13. How do I do logging in C# without using 3rd party libraries? [closed]
  14. C# / F# Performance comparison
  15. String Interpolation vs String.Format
  16. How does extern work in C#?
  17. How performant is StackFrame?
  18. How to force a number to be in a range in C#? [duplicate]
  19. Performance of Find() vs. FirstOrDefault() [duplicate]
  20. Does String.GetHashCode consider the full string or only part of it?
  21. Warm-up when calling methods in C#
  22. LINQ performance FAQ
  23. Is it better to execute many sql commands with one connection, or reconnect every time?
  24. Why is my C# program faster in a profiler?
  25. When to use pointers in C#/.NET?
  26. When to change the Generate Serialization Assembly value?
  27. Slow SoapHttpClientProtocol constructor
  28. Does any one know of a faster method to do String.Split()?
  29. Heap versus Stack allocation implications (.NET)
  30. Why subsequent direct method call is much faster than the first call?

Leave a Comment