How to enable commit on focusLost for TableView/TreeTableView?

by

After some digging, turned out that the culprit (aka: the collaborator that cancels the edit before the textField looses focus) is the TableCellBehaviour/Base in its processing of a mousePressed:

  • mousePressed calls simpleSelect(..)
  • on detecting a single click it calls edit(-1, null)
  • which calls the same method on TableView
  • which sets its editingCell property to null
  • a tableCell listens to that property and reacts by canceling its own edit

Unfortunately, a hackaround requires 3 collaborators

  • a TableView with additional api to terminate an edit
  • a TableCellBehaviour with overridden simpleSelect(...) that calls the additional api (instead of edit(-1..)) before calling super
  • a TableCell that is configured with the extended behaviour and is aware of table’s extended properties

Some code snippets (full code) :

// on XTableView:
public void terminateEdit() {
    if (!isEditing()) return;
    // terminatingCell is a property that supporting TableCells can listen to
    setTerminatingCell(getEditingCell());
    if (isEditing()) throw new IllegalStateException(
          "expected editing to be terminated but was " + getEditingCell());
    setTerminatingCell(null);
}

// on XTableCellBehaviour: override simpleSelect
@Override
protected void simpleSelect(MouseEvent e) {
    TableCell<S, T> cell = getControl();
    TableView<S> table = cell.getTableColumn().getTableView();
    if (table instanceof XTableView) {
        ((XTableView<S>) table).terminateEdit();
    }
    super.simpleSelect(e);
}

// on XTextFieldTableCell - this method is called from listener
// to table's terminatingCell property
protected void terminateEdit(TablePosition<S, ?> newPosition) {
    if (!isEditing() || !match(newPosition)) return;
    commitEdit();
}

protected void commitEdit() {
    T edited = getConverter().fromString(myTextField.getText());
    commitEdit(edited);
}

/**
 * Implemented to create XTableCellSkin which supports terminating edits.
 */
@Override
protected Skin<?> createDefaultSkin() {
    return new XTableCellSkin<S, T>(this);
}

Note: the implementation of TableCellBehaviour changed massively between jdk8u5 and jdk8u20 (joys of hacking – not fit for production use 😉 – the method to override in the latter is handleClicks(..)

BTW: massive votingfor JDK-8089514 (was RT-18492 in old jira) might speed up a core fix. Unfortunately, at least the author role is needed to vote/comment bugs in the new tracker.

More Related Contents:

  1. JavaFX 2.1 TableView refresh items
  2. How can I add rows and columns to a JavaFX 8 TableView
  3. JavaFX: How to change the focus traversal policy?
  4. Detect doubleclick on row of TableView JavaFX
  5. JavaFX Homework [duplicate]
  6. javafx 8 compatibility issues – FXML static fields
  7. Java: How do I start a standalone application from the current one when both are in the same package?
  8. JAVAFX: Location is not set error [duplicate]
  9. Programmatically change the TableView row appearance
  10. Adding Spring Dependency Injection in JavaFX (JPA Repo, Service)
  11. How to UnFocus a JTextField
  12. Optimizing memory leakage in JavaFX
  13. How perform task on JavaFX TextField at onfocus and outfocus?
  14. JavaFX – How to use a method in a controller from another controller?
  15. How to use font awesome in a fxml project (javafx)
  16. How to make EditText not focused when creating Activity
  17. JavaFX – setVisible hides the element but doesn’t rearrange adjacent nodes
  18. How to right align a button in Java FX toolbar
  19. Adding borders to GridPane JavaFX
  20. How to focus object in selenium web driver?
  21. Displaying changing values in JavaFx Label
  22. How to fill up a TableView with database data
  23. Prevent the keyboard from displaying on activity start
  24. Obtaining focus on a JPanel
  25. JavaFx Ensemble on Raspberry pi
  26. JavaFX Maven Plug-in: No plugin found for prefix ‘jfx’ in the current project and in the plugin groups
  27. JavaFX: How to connect two Nodes by a Line?
  28. JavaFx 8: open a link in a browser without reference to Application
  29. Using JavaFX controller without FXML
  30. Correct way to focus an element in Selenium WebDriver using Java

Leave a Comment