How to update-or-insert on a Vec?

by

There is a merged RFC “non-lexical lifetimes” which solves this in the long run. Using the non-lexical lifetimes in Rust 2018, available in Rust 1.31, your code works as-is:

Playground

use std::collections::HashMap;

pub struct Pivot {
    pub min_key: u64,
    pub child: HashMap<u64, ()>,
}

fn update_or_append(pivots: &mut Vec<Pivot>, key: u64, value: ()) {
    match pivots.iter_mut().find(|ref p| key <= p.min_key) {
        Some(pivot) => {
            // If there is one, insert into it and update the pivot key
            pivot.min_key = key;
            pivot.child.insert(key, value);
            return;
        }
        // o/w insert a new leaf at the end
        None => {
            let mut m = HashMap::new();
            m.insert(key, value);
            pivots.push(Pivot {
                min_key: key,
                child: m,
            });
        }
    }
}

fn main() {
    let mut pivots = Vec::new();
    update_or_append(&mut pivots, 100, ());
}

If this doesn’t work for your code, check out

Before Rust 2018, you can workaround it with some additional control flow handling.

You could have your match produce a bool value whether the update happened or not, and have a conditional block below using that value to append. I consider putting the “update-or-append” logic into a separate function (using return after the update) the more idiomatic approach:

Playground

use std::collections::HashMap;

pub struct Pivot {
    pub min_key: u64,
    pub child: HashMap<u64, ()>,
}

fn update_or_append(pivots: &mut Vec<Pivot>, key: u64, value: ()) {
    if let Some(pivot) = pivots.iter_mut().find(|ref p| key <= p.min_key) {
        // If there is one, insert into it and update the pivot key
        pivot.min_key = key;
        pivot.child.insert(key, value);
        return;
    }
    // otherwise insert a new leaf at the end
    let mut m = HashMap::new();
    m.insert(key, value);
    pivots.push(Pivot {
        min_key: key,
        child: m,
    });
}

fn main() {
    let mut pivots = Vec::new();
    update_or_append(&mut pivots, 100, ());
}

Using a bool to track whether the update happened:

Playground

use std::collections::HashMap;

pub struct Pivot {
    pub min_key: u64,
    pub child: HashMap<u64, ()>,
}

fn update_or_append(pivots: &mut Vec<Pivot>, key: u64, value: ()) {
    let updated = match pivots.iter_mut().find(|ref p| key <= p.min_key) {
        Some(pivot) => {
            // If there is one, insert into it and update the pivot key
            pivot.min_key = key;
            pivot.child.insert(key, value);
            true
        }
        // o/w insert a new leaf at the end below
        None => false,
    };
    if !updated {
        let mut m = HashMap::new();
        m.insert(key, value);
        pivots.push(Pivot {
            min_key: key,
            child: m,
        });
    }
}

fn main() {
    let mut pivots = Vec::new();
    update_or_append(&mut pivots, 100, ());
}

More Related Contents:

  1. Why can’t I store a value and a reference to that value in the same struct?
  2. Cannot move out of value which is behind a shared reference when unwrapping
  3. Why does refactoring by extracting a method trigger a borrow checker error?
  4. Temporarily move out of borrowed content
  5. Returning a reference from a HashMap or Vec causes a borrow to last beyond the scope it’s in?
  6. Passing mutable self reference to method of owned object
  7. Mutably borrow one struct field while borrowing another in a closure
  8. Do mutable references have move semantics?
  9. Cannot borrow as immutable because it is also borrowed as mutable in function arguments
  10. Double mutable borrow error in a loop happens even with NLL on
  11. What are the options to end a mutable borrow in Rust?
  12. “borrowed value does not live long enough” when using the builder pattern
  13. How to use struct self in member method closure
  14. Can’t borrow mutably within two different closures in the same scope
  15. Temporary value is freed at the end of this statement [duplicate]
  16. How to use a struct’s member as its own key when inserting the struct into a map without duplicating it?
  17. How can I modify self in a closure called from a member function?
  18. How do I move out of a struct field that is an Option?
  19. Why does this mutable borrow live beyond its scope?
  20. Why can’t I reuse a &mut reference after passing it to a function that accepts a generic type?
  21. How to get a reference to a concrete type from a trait object?
  22. How do I return a reference to something inside a RefCell without breaking encapsulation?
  23. Conditionally iterate over one of several possible iterators
  24. Is there any way to create a type alias for multiple traits?
  25. What’s an idiomatic way to print an iterator separated by spaces in Rust?
  26. How do I return an instance of a trait from a method?
  27. Why is the mutable reference not moved here?
  28. How can I create a function with a variable number of arguments?
  29. What is the purpose of the unit type in Rust?
  30. How to print structs and arrays?

Leave a Comment