How to write this code in simple way?

by

Code Review:

You open the input file in main and open it again in your count_word function. You may get errors from the operating system stating that the file is already open.

A good idea is to close a file before opening it again, or pass the file pointer to the function. You could make the file pointer a global variable, but global variables are evil.

Variable names. If you have to explain the variable’s purpose in a comment, you have named it poorly. Don’t worry about the length of variable names because the length does not affect performance and is negligible in the build time.

The proper method to read until EOF is: 

while ( infile >> ws)

BTW, the variable ws is not defined globally or in the count_word function. The compiler should issue an error message for that.

Words can be input by using a std::string type variable: 

std::string word;
//...
infile >> word; // Read a word.

Prefer not to use the getc method unless your application must read a single character at a time.

Use std::string::length to determine the number of characters in a word.

const unsigned word_length = word.length();
if (word_length == 1)
{
  ++words_of_length_1;
}

Pass by reference for large variables or if the function will modify the variable. Prefer to pass by copy for small variables and constant reference for larger variables.

Your output_table function does not modify its variables, and the variables are small, so pass by copy: 

void output_table(int x, int y, int z, int l) {

More Related Contents:

  1. what is the different between 'new()' int and 'int *p' [closed]
  2. How to optimize traversing a range of numbers?
  3. Can I call a constructor from another constructor (do constructor chaining) in C++?
  4. Why aren’t my include guards preventing recursive inclusion and multiple symbol definitions?
  5. Reading a password from std::cin
  6. Unresolved external symbol in object files
  7. Finding all the subsets of a set
  8. Overloading ++ for both pre and post increment
  9. Is there any “standard” htonl-like function for 64 bits integers in C++?
  10. C++ Winsock P2P
  11. Why don’t the C or C++ standards explicitly define char as signed or unsigned?
  12. What do each memory_order mean?
  13. How to read a growing text file in C++?
  14. 5 years later, is there something better than the “Fastest Possible C++ Delegates”?
  15. When should you use the “this” keyword in C++? [duplicate]
  16. how to test a string for letters only
  17. What is the difference between a static and const variable?
  18. Implementing a std::vector like container without undefined behavior
  19. GCC: Difference between -O3 and -Os
  20. Using bts assembly instruction with gcc compiler
  21. Why sizeof int is wrong, while sizeof(int) is right?
  22. Add Library to Visual Studio 2008 C++ Project
  23. Does C have One Definition Rule like C++?
  24. Why does pointer to int convert to void* but pointer to function convert to bool?
  25. Why do (only) some compilers use the same address for identical string literals?
  26. Get private data members for non intrusive boost serialization C++
  27. Finding square root without using sqrt function?
  28. Where can I find an official reference listing the operation of SSE intrinsic functions?
  29. How do I include the string header?
  30. Howto: c++ Function Pointer with default values

Leave a Comment