ifstream not reading EOF character

by

First thing is first, you shouldn’t check like that. eof() doesn’t return true until after a failed read. But you can do better (and easier)!

check the stream state with the implicit conversion to void* which can be used in a bool context. Since most of the read operations on streams return a reference to the stream, you can write some very consice code like this:

std::string line;
while(std::getline(currentfile, line)) {
    // process line
}

Basically what it is doing is saying “while I could successfully extract a line from currentfile, do the following”, which is what you really meant to say anyway ;-);

Like I said, this applies to most stream operations, so you can do things like this:

int x;
std::string y;
if(std::cin >> x >> y) {
    // successfully read an integer and a string from cin!
}

EDIT: The way I would rewrite your code is like this:

string line;
unsigned long pos = 0;
int linenumber = 0;

ifstream curfile(input.c_str());

std::cout << "About to try to read the file" << std::endl;
while (std::getline(curfile, line)) {

    std::cout << "Getting line " << linenumber << std::endl;
    linenumber++;

    // do the rest of the work with line
}

More Related Contents:

  1. How does ifstream’s eof() work?
  2. How to extract a multiline text segment between two delimiters under a certain heading from a text file using C++ [closed]
  3. Fast textfile reading in c++
  4. Getting std :: ifstream to handle LF, CR, and CRLF?
  5. tellg() function give wrong size of file?
  6. eof() bad practice? [duplicate]
  7. Do I need to manually close an ifstream?
  8. Checking for an empty file in C++
  9. Can we write an EOF character ourselves?
  10. reading a line from ifstream into a string variable
  11. How to signify no more input for string ss in the loop while (cin >> ss)
  12. C++ ifstream failbit and badbit
  13. How to write to middle of a file in C++?
  14. Why is failbit set when eof is found on read?
  15. What is value of EOF and ‘\0’ in C
  16. End of File in C++
  17. How can I use non-default delimiters when reading a text file with std::fstream?
  18. Replace a line in text file
  19. How to read huge file in c++
  20. How to count lines of a file in C++?
  21. Reading a Matrix txt file and storing as an array
  22. C++ ifstream error using string as opening file path.
  23. C static keyword vs C++ private scope?
  24. Injected class name compiler discrepancy
  25. Overloading on R-value references and code duplication
  26. Direct way of computing the clockwise angle between two vectors
  27. Sorting a list of a custom type
  28. Do non-static member variables in a C++ struct/class need to be marked as volatile to be treated as volatile in a member function?
  29. if constexpr – why is discarded statement fully checked?
  30. Getting an array of bytes out of Windows::Storage::Streams::IBuffer

Leave a Comment