End of File in C++

by

This is the wrong way to read a file:

while (!fin.eof( ))
{
      // readLine;
      // Do Stuff
}

The standard pattern is:

while(getlineOrValues)
{
    // Do Stuff
}

So looking at your code quickly I think it would be asier to write it as:

while(fin>>c_tmp>>gamma_tmp)
{
    // loop only eneterd if both c_tmp AND gamma_tmp
    // can be retrieved from the file.

    cs_bit.push_back(c_tmp);
    gammas_bit.push_back(gamma_tmp);
    nb_try++;   
}

The problem is that EOF is only true AFTER you try and read past it. Having no character left in the file to read is not the same as EOF being true. So you read the last line and get values and there is nothing left to read, but EOF is still false so the code re-enter the loop. When it tries and read the c_tmp then EOF gets triggered and your asserts go pear shaped.

The solution is to put the read as the while condition. The result of doing the read is the stream. But when a stream is used in a boolean context (such as a while condition) it is converted into a type that can be used as like a bool (Technically it is a void* but thats not important).

More Related Contents:

  1. eof() bad practice? [duplicate]
  2. How does ifstream’s eof() work?
  3. Checking for an empty file in C++
  4. Can we write an EOF character ourselves?
  5. How to signify no more input for string ss in the loop while (cin >> ss)
  6. Why is failbit set when eof is found on read?
  7. What is value of EOF and ‘\0’ in C
  8. ifstream not reading EOF character
  9. Uses of C comma operator [duplicate]
  10. C++ std::set update is tedious: I can’t change an element in place
  11. Deploying Qt 5 App on Windows
  12. Why SDL defines main macro?
  13. Function with missing return value, behavior at runtime
  14. ‘size_t’ vs ‘container::size_type’
  15. how do I print an unsigned char as hex in c++ using ostream?
  16. difference between a pointer and reference parameter?
  17. Object creation on the stack/heap?
  18. Explain Morris inorder tree traversal without using stacks or recursion
  19. splitting a string into an array in C++ without using vector
  20. How should I use FormatMessage() properly in C++?
  21. A fast method to round a double to a 32-bit int explained
  22. What is the difference between packaged_task and async
  23. source code of c/c++ functions
  24. C++ auto vs auto&
  25. checking for eof in string::getline
  26. C++ terminate called without an active exception
  27. What does int() do in C++?
  28. Where should non-member operator overloads be placed?
  29. How to implement readlink to find the path
  30. Initializing an std::array of non-default-constructible elements?

Leave a Comment