Improve condition check

by

You can just combine all four conditions into one using logical operators. For example by using logical and && and logical or ||. It could then look like:

if ((first && second) || (third && fourth)) {
    return true;
}

Or with all conditions substituted:

if ((Obj.getSource().equals("abc") && Obj.getDest().equals("bcd"))
        || (Obj.getSource().equals("abd") && Obj.getDest().equals("gdc"))) {
    return true;
}

Note that you may memorize the result of Obj.getSource() and Obj.getDest() in a variable in order to save some performance and make the condition more readable by using that variable instead.

And if you would return false; in the other cases you could even completely leave out the whole if as you could directly return the boolean resulting after evaluating the condition (it evaluates to either true or false, no need to return true and false hardcoded then):

return (first && second) || (third && fourth);

More Related Contents:

  1. Java 8 List into Map
  2. finalize() called on strongly reachable objects in Java 8
  3. Comparator.reversed() does not compile using lambda
  4. Java 8: Difference between two LocalDateTime in multiple units
  5. Why is the max recursion depth I can reach non-deterministic?
  6. HashMap Java 8 implementation
  7. Collection to stream to a new collection
  8. Purpose of Default or Defender methods in Java 8
  9. Java 8 stream’s .min() and .max(): why does this compile?
  10. Java 8 method reference unhandled exception
  11. Differences between Java 8 Date Time API (java.time) and Joda-Time
  12. Lambda expression and method overloading doubts
  13. Why does Collections.sort use Mergesort but Arrays.sort does not?
  14. No IDEA annotations attached to the JDK 1.8 (C:\…), some issues will not be found
  15. Java 8 chained method reference?
  16. Why can’t I throw an exception in a Java 8 lambda expression? [duplicate]
  17. Sort map by value using lambdas and streams
  18. Do lambda expressions have any use other than saving lines of code?
  19. Java 8 forEach with index [duplicate]
  20. What is a Java 8 Lambda Expression Compiled to? [duplicate]
  21. incompatible types: inference variable T has incompatible bounds [duplicate]
  22. Super class method and Interface default method conflict resolution
  23. Java idiom for lambdas with non-SAM interfaces
  24. Modifying Objects within stream in Java8 while iterating
  25. Valid usage of Optional type in Java 8
  26. installing JDK8 on Windows XP – advapi32.dll error
  27. How to set format of string for java.time.Instant using objectMapper?
  28. When is an interface with a default method initialized?
  29. java: Arrays.sort() with lambda expression
  30. Cannot use Java 8 method with lambda arguments without specifying type arguments

Leave a Comment